Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: ios/chrome/browser/ui/activity_services/activity_type_util.mm

Issue 2752643004: Stop showing snackbar with success message when sharing with Chrome iOS. (Closed)
Patch Set: Addressed comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/activity_services/activity_type_util.mm
diff --git a/ios/chrome/browser/ui/activity_services/activity_type_util.mm b/ios/chrome/browser/ui/activity_services/activity_type_util.mm
index 0675a00194ccd24d7cd6dc1547220e2c046da557..8a8378ef3f7e8d98f24e62d4a1183afd1d46f52f 100644
--- a/ios/chrome/browser/ui/activity_services/activity_type_util.mm
+++ b/ios/chrome/browser/ui/activity_services/activity_type_util.mm
@@ -104,22 +104,13 @@ bool IsPasswordAppExActivity(NSString* activityString) {
return PasswordAppExActivityVersion(activityString) != nil;
}
-NSString* SuccessMessageForActivity(ActivityType type) {
+NSString* CompletionMessageForActivity(ActivityType type) {
+ // Some activities can be reported as completed even if not successful.
+ // Make sure that the message is meaningful even if the activity completed
+ // unsuccessfully.
switch (type) {
case NATIVE_CLIPBOARD:
return l10n_util::GetNSString(IDS_IOS_SHARE_TO_CLIPBOARD_SUCCESS);
- case NATIVE_FACEBOOK:
- return l10n_util::GetNSString(IDS_IOS_SHARE_FACEBOOK_COMPLETE);
- case NATIVE_MAIL:
- return l10n_util::GetNSString(IDS_IOS_SHARE_EMAIL_COMPLETE);
- case NATIVE_MESSAGE:
- return l10n_util::GetNSString(IDS_IOS_SHARE_MESSAGES_COMPLETE);
- case NATIVE_TWITTER:
- return l10n_util::GetNSString(IDS_IOS_SHARE_TWITTER_COMPLETE);
- case GOOGLE_GMAIL:
- return l10n_util::GetNSString(IDS_IOS_SHARE_EMAIL_COMPLETE);
- case GOOGLE_GOOGLEPLUS:
- return l10n_util::GetNSString(IDS_IOS_SHARE_GPLUS_COMPLETE);
case APPEX_PASSWORD_MANAGEMENT_1PASSWORD:
case APPEX_PASSWORD_MANAGEMENT_LASTPASS:
case APPEX_PASSWORD_MANAGEMENT_DASHLANE:

Powered by Google App Engine
This is Rietveld 408576698