ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm - Issue 2752643004: Stop showing snackbar with success message when sharing with Chrome iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm

Issue 2752643004: Stop showing snackbar with success message when sharing with Chrome iOS. (Closed)

Patch Set: Addressed comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/activity_services/activity_type_util.mm ('k') | ios/chrome/browser/ui/activity_services/share_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm

diff --git a/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm b/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm

index bec7679140c35ea10c13d8ecfa218d173fe2bbac..42b384c9fc1f0d0ac41f2aa1ca611a738198f5b1 100644

--- a/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm

+++ b/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm

@@ -41,7 +41,7 @@ TEST(ActivityTypeUtilTest, StringToTypeTest) {

void TypeToMessageTestHelper(activity_type_util::ActivityType type,

NSString* expectedMessage) {

- EXPECT_NSEQ(activity_type_util::SuccessMessageForActivity(type),

+ EXPECT_NSEQ(activity_type_util::CompletionMessageForActivity(type),

expectedMessage);

}

@@ -49,8 +49,8 @@ TEST(ActivityTypeUtilTest, TypeToMessageTest) {

TypeToMessageTestHelper(activity_type_util::UNKNOWN, nil);

TypeToMessageTestHelper(activity_type_util::PRINT, nil);

TypeToMessageTestHelper(

- activity_type_util::NATIVE_TWITTER,

- l10n_util::GetNSString(IDS_IOS_SHARE_TWITTER_COMPLETE));

+ activity_type_util::NATIVE_CLIPBOARD,

+ l10n_util::GetNSString(IDS_IOS_SHARE_TO_CLIPBOARD_SUCCESS));

TypeToMessageTestHelper(

activity_type_util::APPEX_PASSWORD_MANAGEMENT_OTHERS,

l10n_util::GetNSString(IDS_IOS_APPEX_PASSWORD_FORM_FILLED_SUCCESS));