Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: ios/chrome/browser/ui/browser_view_controller_unittest.mm

Issue 2752643004: Stop showing snackbar with success message when sharing with Chrome iOS. (Closed)
Patch Set: Addressed comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller_unittest.mm b/ios/chrome/browser/ui/browser_view_controller_unittest.mm
index 45354be1be2d842ad436d25859b97fe9657a4c9b..b8620b84c907bddeb93919eb79ddd430dd6748a3 100644
--- a/ios/chrome/browser/ui/browser_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/browser_view_controller_unittest.mm
@@ -469,10 +469,11 @@ TEST_F(BrowserViewControllerTest, TestSharePageWhenClosing) {
// Verifies that BVC instantiates a bubble to show the given success message on
// receiving a -shareDidComplete callback for a successful share.
TEST_F(BrowserViewControllerTest, TestShareDidCompleteWithSuccess) {
- NSString* successMessage = @"Success";
- [[dependencyFactory_ expect] showSnackbarWithMessage:successMessage];
+ NSString* completionMessage = @"Completion!";
+ [[dependencyFactory_ expect] showSnackbarWithMessage:completionMessage];
- [bvc_ shareDidComplete:ShareTo::SHARE_SUCCESS successMessage:successMessage];
+ [bvc_ shareDidComplete:ShareTo::SHARE_SUCCESS
+ completionMessage:completionMessage];
EXPECT_OCMOCK_VERIFY(dependencyFactory_);
}
@@ -493,7 +494,7 @@ TEST_F(BrowserViewControllerTest, TestShareDidCompleteWithError) {
viewController:OCMOCK_ANY];
[static_cast<AlertCoordinator*>([mockCoordinator expect]) start];
- [bvc_ shareDidComplete:ShareTo::SHARE_ERROR successMessage:@"dummy"];
+ [bvc_ shareDidComplete:ShareTo::SHARE_ERROR completionMessage:@"dummy"];
EXPECT_OCMOCK_VERIFY(dependencyFactory_);
EXPECT_OCMOCK_VERIFY(mockCoordinator);
}
@@ -506,7 +507,7 @@ TEST_F(BrowserViewControllerTest, TestShareDidCompleteWithCancellation) {
message:OCMOCK_ANY
viewController:OCMOCK_ANY];
- [bvc_ shareDidComplete:ShareTo::SHARE_CANCEL successMessage:@"dummy"];
+ [bvc_ shareDidComplete:ShareTo::SHARE_CANCEL completionMessage:@"dummy"];
EXPECT_OCMOCK_VERIFY(dependencyFactory_);
}
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698