Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

Issue 2752643004: Stop showing snackbar with success message when sharing with Chrome iOS. (Closed)
Patch Set: Addressed comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm b/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
index 48a6e633d0d4ca05e5f392228069a6416ab905eb..dc0e5b7f51d2e05c8113972d6db94370b8989455 100644
--- a/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
+++ b/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
@@ -164,27 +164,27 @@ class ActivityServiceControllerTest : public PlatformTest {
passwordAppExDidFinish:ShareTo::ShareResult::SHARE_CANCEL
username:OCMOCK_ANY
password:OCMOCK_ANY
- successMessage:OCMOCK_ANY];
+ completionMessage:OCMOCK_ANY];
[[[shareToDelegateMock stub] andDo:validationBlock]
passwordAppExDidFinish:ShareTo::ShareResult::SHARE_NETWORK_FAILURE
username:OCMOCK_ANY
password:OCMOCK_ANY
- successMessage:OCMOCK_ANY];
+ completionMessage:OCMOCK_ANY];
[[[shareToDelegateMock stub] andDo:validationBlock]
passwordAppExDidFinish:ShareTo::ShareResult::SHARE_SIGN_IN_FAILURE
username:OCMOCK_ANY
password:OCMOCK_ANY
- successMessage:OCMOCK_ANY];
+ completionMessage:OCMOCK_ANY];
[[[shareToDelegateMock stub] andDo:validationBlock]
passwordAppExDidFinish:ShareTo::ShareResult::SHARE_ERROR
username:OCMOCK_ANY
password:OCMOCK_ANY
- successMessage:OCMOCK_ANY];
+ completionMessage:OCMOCK_ANY];
[[[shareToDelegateMock stub] andDo:validationBlock]
passwordAppExDidFinish:ShareTo::ShareResult::SHARE_UNKNOWN_RESULT
username:OCMOCK_ANY
password:OCMOCK_ANY
- successMessage:OCMOCK_ANY];
+ completionMessage:OCMOCK_ANY];
[activityController setShareToDelegateForTesting:(id)shareToDelegateMock];
// Sets up the returned item from a Password Management App Extension.
@@ -209,7 +209,7 @@ class ActivityServiceControllerTest : public PlatformTest {
TEST_F(ActivityServiceControllerTest, PresentAndDismissController) {
[[shareToDelegate_ expect] shareDidComplete:ShareTo::ShareResult::SHARE_CANCEL
- successMessage:[OCMArg isNil]];
+ completionMessage:[OCMArg isNil]];
UIViewController* parentController =
static_cast<UIViewController*>(parentController_);
@@ -351,7 +351,7 @@ TEST_F(ActivityServiceControllerTest, ProcessItemsReturnedSuccessfully) {
[[ActivityServiceController alloc] init];
// Sets up a Mock ShareToDelegate object to check that the callback function
- // -passwordAppExDidFinish:username:password:successMessage:
+ // -passwordAppExDidFinish:username:password:completionMessage:
// is correct with the correct username and password.
OCMockObject* shareToDelegateMock =
[OCMockObject mockForProtocol:@protocol(ShareToDelegate)];
@@ -372,7 +372,7 @@ TEST_F(ActivityServiceControllerTest, ProcessItemsReturnedSuccessfully) {
passwordAppExDidFinish:ShareTo::ShareResult::SHARE_SUCCESS
username:OCMOCK_ANY
password:OCMOCK_ANY
- successMessage:OCMOCK_ANY];
+ completionMessage:OCMOCK_ANY];
[activityController setShareToDelegateForTesting:(id)shareToDelegateMock];
// Sets up the returned item from a Password Management App Extension.
@@ -392,7 +392,7 @@ TEST_F(ActivityServiceControllerTest, ProcessItemsReturnedSuccessfully) {
status:result
items:@[ extensionItem ]];
ASSERT_FALSE(resetUI);
- // Wait for -passwordAppExDidFinish:username:password:successMessage:
+ // Wait for -passwordAppExDidFinish:username:password:completionMessage:
// to be called.
base::test::ios::WaitUntilCondition(^{
return blockCalled;

Powered by Google App Engine
This is Rietveld 408576698