Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Turn ConsoleModel into a singleton This effectively merges ConsoleModel and MultitargetConsoleModel. This is in preparation to extracting ConsoleModel out of SDK and turning it into ConsoleView's presentation model. BUG=none Review-Url: https://codereview.chromium.org/2751173003 Cr-Commit-Position: refs/heads/master@{#457354} Committed: https://chromium.googlesource.com/chromium/src/+/a91e5309d953abb795f3c10f10609fec72a6bbfa

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -234 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-preserve-log.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-revoke-error-in-worker.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/input-event-warning.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 6 chunks +13 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 3 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 12 chunks +92 lines, -177 lines 4 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/LogModel.js View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2748023006 Patch 20001

Dependent Patchsets:

Issue 2751193003 Patch 1

Messages

Total messages: 8 (4 generated)
dgozman
Could you please take a look?
3 years, 9 months ago (2017-03-15 22:03:56 UTC) #2
caseq
lgtm https://codereview.chromium.org/2751173003/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js (right): https://codereview.chromium.org/2751173003/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js#newcode202 third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:202: * @param {!SDK.RuntimeModel} runtimeModel you only use target, ...
3 years, 9 months ago (2017-03-16 00:38:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751173003/20001
3 years, 9 months ago (2017-03-16 02:34:51 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 05:00:37 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a91e5309d953abb795f3c10f1060...

Powered by Google App Engine
This is Rietveld 408576698