[DevTools] Make ConsoleModel not inherit from SDKModel

[DevTools] Make ConsoleModel not inherit from SDKModel

SDK.MultiTargetConsoleModel now manages ConsoleModel instances.

This is in preparation to extracting ConsoleModel out of SDK and
turning it into ConsoleView's presentation model.

BUG=none

Review-Url: https://codereview.chromium.org/2748023006
Cr-Commit-Position: refs/heads/master@{#457304}
Committed: https://chromium.googlesource.com/chromium/src/+/524166ab8948e4348526fda14e5a834b45d730fe

[dgozman, 2017-03-15 21:18:29]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-03-15 21:18:44]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-03-15 21:18:45]

Could you please take a look?

[commit-bot: I haz the power, 2017-03-15 21:19:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2017-03-15 21:32:01]

lgtm

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js (right):

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:84: target() {
drop this and keep it private?

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:645:
SDK.MultitargetConsoleModel = class extends Common.Object {
This is really MultitargetLogModel, right?

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:660:
consoleModel[SDK.MultitargetConsoleModel._events] = [
nit: you keep a map of all models anyway, so these listeners could rather be
there.

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:146:
console.error(new Error().stack);
Is this a stray change? Let's at least have some reassuring words in the console
message.

[dgozman, 2017-03-15 23:08:13]

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js (right):

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:645:
SDK.MultitargetConsoleModel = class extends Common.Object {
On 2017/03/15 21:32:01, caseq wrote:
> This is really MultitargetLogModel, right?

Not really. It's a model for ConsoleView mostly.

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2748023006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:146:
console.error(new Error().stack);
On 2017/03/15 21:32:01, caseq wrote:
> Is this a stray change? Let's at least have some reassuring words in the
console
> message.

Stray change, thanks! Removed.

[dgozman, 2017-03-15 23:08:18]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 23:08:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:40:33]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-03-16 01:46:52]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-16 01:46:53]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2748023006/#ps20001
(title: "stray change")

[commit-bot: I haz the power, 2017-03-16 01:47:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:51:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489628812805060,
"parent_rev": "480869caaa149d728cbc2381476dbb5a153dc652", "commit_rev":
"524166ab8948e4348526fda14e5a834b45d730fe"}

[commit-bot: I haz the power, 2017-03-16 01:52:31]

Description was changed from

==========
[DevTools] Make ConsoleModel not inherit from SDKModel

SDK.MultiTargetConsoleModel now manages ConsoleModel instances.

This is in preparation to extracting ConsoleModel out of SDK and
turning it into ConsoleView's presentation model.

BUG=none
==========

to

==========
[DevTools] Make ConsoleModel not inherit from SDKModel

SDK.MultiTargetConsoleModel now manages ConsoleModel instances.

This is in preparation to extracting ConsoleModel out of SDK and
turning it into ConsoleView's presentation model.

BUG=none

Review-Url: https://codereview.chromium.org/2748023006
Cr-Commit-Position: refs/heads/master@{#457304}
Committed:
https://chromium.googlesource.com/chromium/src/+/524166ab8948e4348526fda14e5a...
==========

[commit-bot: I haz the power, 2017-03-16 01:52:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/524166ab8948e4348526fda14e5a...