third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js - Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton (Closed)

Patch Set: rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

index 4278f1ef34b8ee78e492a83c24d3df015fa30838..b7a4b9c5b792dda907ef6be2f932b3cbc3140227 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

@@ -987,7 +987,7 @@ SDK.targetManager.observeTargets({

InspectorTest.serviceWorkerManager = target.model(SDK.ServiceWorkerManager);

InspectorTest.tracingManager = target.model(SDK.TracingManager);

InspectorTest.mainTarget = target;

- Promise.resolve().then(() => { InspectorTest.consoleModel = SDK.multitargetConsoleModel._consoleModels.get(target); });

+ InspectorTest.consoleModel = SDK.consoleModel;

targetRemoved: function(target) { }