third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js - Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton (Closed)

Patch Set: rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/Tests.js ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

index 591ba994043baab9ce405c516fa94a17e8391198..cb1e5870959ca30d6528c81fefb4127d0bbe5a9d 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

@@ -44,10 +44,9 @@ Bindings.PresentationConsoleMessageHelper = class {

/** @type {!Array.<!Bindings.PresentationConsoleMessage>} */

this._presentationConsoleMessages = [];

- SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);

- SDK.multitargetConsoleModel.addEventListener(

- SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this);

- SDK.multitargetConsoleModel.messages().forEach(this._consoleMessageAdded, this);

+ SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);

+ SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this);

+ SDK.consoleModel.messages().forEach(this._consoleMessageAdded, this);

// TODO(dgozman): setImmediate because we race with DebuggerWorkspaceBinding on ParsedScriptSource event delivery.

SDK.targetManager.addModelListener(

SDK.DebuggerModel, SDK.DebuggerModel.Events.ParsedScriptSource,