third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html - Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton (Closed)

Patch Set: rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html ('k') | third_party/WebKit/LayoutTests/inspector/input-event-warning.html » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

diff --git a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

index f024d783ddc82451eecb4e39af98f0dfd3302ee5..4945678a2779a3f7b64438bd5240139adcb8957f 100644

--- a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

+++ b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html

@@ -64,11 +64,11 @@ function initialize_extensionsPanelTest()

InspectorTest.disableConsoleViewport();

InspectorTest.evaluateInPage("logMessage()");

var wrappedConsoleMessageAdded = InspectorTest.safeWrap(consoleMessageAdded);

- SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded);

+ SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded);

function consoleMessageAdded()

{

- SDK.multitargetConsoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded);

+ SDK.consoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded);

Console.ConsoleView.instance()._viewportThrottler.flush();

InspectorTest.deprecatedRunAfterPendingDispatches(clickOnMessage)

}