Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2751193003: [DevTools] Move ConsoleModel to it's own module (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move ConsoleModel to it's own module This finally moves ConsoleModel out of sdk. NetworkLog is next. BUG=none Review-Url: https://codereview.chromium.org/2751193003 Cr-Commit-Position: refs/heads/master@{#457499} Committed: https://chromium.googlesource.com/chromium/src/+/5f6c9c530b8cda7429c2ca86655439b5ea952b40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -946 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-throw.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-preserve-log.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-revoke-error.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-revoke-error-in-worker.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tests.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/input-event-warning.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/monitor-console-command.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 6 chunks +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 5 chunks +14 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 17 chunks +55 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 15 chunks +46 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js View 28 chunks +82 lines, -86 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/console_model/module.json View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +0 lines, -678 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js View 1 chunk +4 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
dgozman
This patch was generated with extract_module.js script! Please take a look.
3 years, 9 months ago (2017-03-15 23:46:33 UTC) #2
caseq
lgtm
3 years, 9 months ago (2017-03-16 00:48:58 UTC) #3
pfeldman
Is there a bug to understand why this all is happening?
3 years, 9 months ago (2017-03-16 00:53:55 UTC) #4
dgozman
On 2017/03/16 00:53:55, pfeldman_slow wrote: > Is there a bug to understand why this all ...
3 years, 9 months ago (2017-03-16 01:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751193003/1
3 years, 9 months ago (2017-03-16 16:59:32 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 18:30:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f6c9c530b8cda7429c2ca866554...

Powered by Google App Engine
This is Rietveld 408576698