Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2744273002: Fix leaking of AddToHomescreenManager for WebAPKs. (Closed)

Created:
3 years, 9 months ago by Xi Han
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix leaking of AddToHomescreenManager for WebAPKs. Currently, AddToHomescreenManager is never destroyed when installing a WebAPK. In this CL, we add a JNI call in the native side to destroy AddToHomescreenManager after creating an install infobar for WebAPKs. BUG=688444 Review-Url: https://codereview.chromium.org/2738823008 Cr-Commit-Position: refs/heads/master@{#455594} (cherry picked from commit aefa25eb71bb437576f9b0f1b093b9909a211f62) Review-Url: https://codereview.chromium.org/2744273002 . Cr-Commit-Position: refs/branch-heads/3029@{#145} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/200438fbc2dde571fc36dce8cf6bf9baa8b1bcf2

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Xi Han
3 years, 9 months ago (2017-03-13 13:54:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
200438fbc2dde571fc36dce8cf6bf9baa8b1bcf2.

Powered by Google App Engine
This is Rietveld 408576698