Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/browser/android/webapps/add_to_homescreen_manager.cc

Issue 2744273002: Fix leaking of AddToHomescreenManager for WebAPKs. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/webapps/add_to_homescreen_manager.h" 5 #include "chrome/browser/android/webapps/add_to_homescreen_manager.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 const SkBitmap& badge_icon) { 164 const SkBitmap& badge_icon) {
165 if (is_webapk_compatible_) { 165 if (is_webapk_compatible_) {
166 // TODO(zpeng): Add badge to WebAPK installation flow. 166 // TODO(zpeng): Add badge to WebAPK installation flow.
167 WebApkInstallService* install_service = 167 WebApkInstallService* install_service =
168 WebApkInstallService::Get( 168 WebApkInstallService::Get(
169 data_fetcher_->web_contents()->GetBrowserContext()); 169 data_fetcher_->web_contents()->GetBrowserContext());
170 if (install_service->IsInstallInProgress(info.manifest_url)) 170 if (install_service->IsInstallInProgress(info.manifest_url))
171 ShortcutHelper::ShowWebApkInstallInProgressToast(); 171 ShortcutHelper::ShowWebApkInstallInProgressToast();
172 else 172 else
173 CreateInfoBarForWebApk(info, primary_icon); 173 CreateInfoBarForWebApk(info, primary_icon);
174
175 JNIEnv* env = base::android::AttachCurrentThread();
176 Java_AddToHomescreenManager_onFinished(env, java_ref_);
174 return; 177 return;
175 } 178 }
176 179
177 JNIEnv* env = base::android::AttachCurrentThread();
178 ScopedJavaLocalRef<jobject> java_bitmap; 180 ScopedJavaLocalRef<jobject> java_bitmap;
179 if (!primary_icon.drawsNothing()) 181 if (!primary_icon.drawsNothing())
180 java_bitmap = gfx::ConvertToJavaBitmap(&primary_icon); 182 java_bitmap = gfx::ConvertToJavaBitmap(&primary_icon);
181 183
184 JNIEnv* env = base::android::AttachCurrentThread();
182 Java_AddToHomescreenManager_onReadyToAdd(env, java_ref_, java_bitmap); 185 Java_AddToHomescreenManager_onReadyToAdd(env, java_ref_, java_bitmap);
183 186
184 if (add_shortcut_pending_) 187 if (add_shortcut_pending_)
185 AddShortcut(info, primary_icon); 188 AddShortcut(info, primary_icon);
186 } 189 }
187 190
188 void AddToHomescreenManager::CreateInfoBarForWebApk(const ShortcutInfo& info, 191 void AddToHomescreenManager::CreateInfoBarForWebApk(const ShortcutInfo& info,
189 const SkBitmap& icon) { 192 const SkBitmap& icon) {
190 banners::AppBannerInfoBarDelegateAndroid::Create( 193 banners::AppBannerInfoBarDelegateAndroid::Create(
191 data_fetcher_->web_contents(), nullptr, info.user_title, 194 data_fetcher_->web_contents(), nullptr, info.user_title,
192 base::MakeUnique<ShortcutInfo>(info), base::MakeUnique<SkBitmap>(icon), 195 base::MakeUnique<ShortcutInfo>(info), base::MakeUnique<SkBitmap>(icon),
193 -1 /* event_request_id */, webapk::INSTALL_SOURCE_MENU); 196 -1 /* event_request_id */, webapk::INSTALL_SOURCE_MENU);
194 } 197 }
195 198
196 SkBitmap AddToHomescreenManager::FinalizeLauncherIconInBackground( 199 SkBitmap AddToHomescreenManager::FinalizeLauncherIconInBackground(
197 const SkBitmap& bitmap, 200 const SkBitmap& bitmap,
198 const GURL& url, 201 const GURL& url,
199 bool* is_generated) { 202 bool* is_generated) {
200 DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread()); 203 DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
201 204
202 return ShortcutHelper::FinalizeLauncherIconInBackground(bitmap, url, 205 return ShortcutHelper::FinalizeLauncherIconInBackground(bitmap, url,
203 is_generated); 206 is_generated);
204 } 207 }
OLDNEW
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698