chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java - Issue 2744273002: Fix leaking of AddToHomescreenManager for WebAPKs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java

Issue 2744273002: Fix leaking of AddToHomescreenManager for WebAPKs. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java

index af284a128df59f10e62143e72f8c8b5f15b02e38..be96d08105cbf7d2f8e4f0692f5e15d4e201fc2c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java

@@ -68,7 +68,8 @@ public class AddToHomescreenManager {

nativeAddShortcut(mNativeAddToHomescreenManager, userRequestedTitle);

}

- public void onDismissed() {

+ @CalledByNative

+ public void onFinished() {

destroy();

}