chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java - Issue 2744273002: Fix leaking of AddToHomescreenManager for WebAPKs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

Issue 2744273002: Fix leaking of AddToHomescreenManager for WebAPKs. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

index f0e076f56241049d6dd0def099c2a181b521b56d..065a85a1557dd3d9cb3d46a43635b33339ea9a24 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

@@ -127,7 +127,7 @@ public class AddToHomescreenDialog implements AddToHomescreenManager.Observer {

@Override

public void onDismiss(DialogInterface dialog) {

mDialog = null;

- mManager.onDismissed();

+ mManager.onFinished();

}

});

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java » ('j') | no next file with comments »