Fix leaking of AddToHomescreenManager for WebAPKs.

Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we add a JNI call in the native side to destroy 
AddToHomescreenManager after creating an install infobar for WebAPKs.

BUG=688444
Review-Url: https://codereview.chromium.org/2738823008
Cr-Commit-Position: refs/heads/master@{#455594}
Committed: https://chromium.googlesource.com/chromium/src/+/aefa25eb71bb437576f9b0f1b093b9909a211f62

[Xi Han, 2017-03-08 21:30:26]

hanxi@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[Xi Han, 2017-03-08 21:30:26]

Hi Peter, could you please take a look? Thanks!

[pkotwicz, 2017-03-08 21:56:37]

Description was changed from

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed for WebAPKs. In this CL, we
add a Jni call in the native side to destroy AddToHomescreenManager after
creating an install infobar for WebAPKs.

BUG=688444
==========

to

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a  WebAPK.
In this CL, we
add a JNI call in the native side to destroy AddToHomescreenManager after
creating an install infobar for WebAPKs.

BUG=688444
==========

[pkotwicz, 2017-03-08 21:57:29]

LGTM with nits

https://codereview.chromium.org/2738823008/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java
(right):

https://codereview.chromium.org/2738823008/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java:70:

Maybe rename finish() to onFinished() and make AddToHomescreenDialog call
onFinished() as well instead of onDismissed(). That way we don't have too many
methods :)

https://codereview.chromium.org/2738823008/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapps/add_to_homescreen_manager.cc (right):

https://codereview.chromium.org/2738823008/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapps/add_to_homescreen_manager.cc:165: JNIEnv* env =
base::android::AttachCurrentThread();
Nit: Can you move this right before you call
Java_AddToHomescreenManager_finish() ?

[Xi Han, 2017-03-08 22:07:36]

Description was changed from

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a  WebAPK.
In this CL, we
add a JNI call in the native side to destroy AddToHomescreenManager after
creating an install infobar for WebAPKs.

BUG=688444
==========

to

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a  WebAPK.
In this CL, we
add a JNI call in the native side to destroy AddToHomescreenManager after
creating an install infobar for WebAPKs.

BUG=692249
==========

[Xi Han, 2017-03-08 22:13:04]

Patchset #2 (id:20001) has been deleted

[Xi Han, 2017-03-08 22:13:52]

hanxi@chromium.org changed reviewers:
+ dominickn@chromium.org

[Xi Han, 2017-03-08 22:13:52]

Hi Dominick, could you please take a look? Thanks!

https://codereview.chromium.org/2738823008/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java
(right):

https://codereview.chromium.org/2738823008/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java:70:

On 2017/03/08 21:57:29, pkotwicz wrote:
> Maybe rename finish() to onFinished() and make AddToHomescreenDialog call
> onFinished() as well instead of onDismissed(). That way we don't have too many
> methods :)

Done.

https://codereview.chromium.org/2738823008/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapps/add_to_homescreen_manager.cc (right):

https://codereview.chromium.org/2738823008/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapps/add_to_homescreen_manager.cc:165: JNIEnv* env =
base::android::AttachCurrentThread();
On 2017/03/08 21:57:29, pkotwicz wrote:
> Nit: Can you move this right before you call
> Java_AddToHomescreenManager_finish() ?

I move it here since both line 175 and 183 use the |env|. Yes, it would be nicer
if it is closed to the jni call. Updated.

[dominickn, 2017-03-08 22:55:59]

lgtm, thanks

Please indent the description properly.

[dominickn, 2017-03-08 22:56:19]

On 2017/03/08 22:55:59, dominickn wrote:
> lgtm, thanks
> 
> Please indent the description properly.

Also, we shouldn't ship WebAPKs without this patch.

[Xi Han, 2017-03-08 22:56:48]

Description was changed from

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a  WebAPK.
In this CL, we
add a JNI call in the native side to destroy AddToHomescreenManager after
creating an install infobar for WebAPKs.

BUG=692249
==========

to

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a  WebAPK.
In this CL, we add a JNI call in the native side to destroy
AddToHomescreenManager
after creating an install infobar for WebAPKs.

BUG=692249
==========

[Xi Han, 2017-03-08 22:57:41]

Description was changed from

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a  WebAPK.
In this CL, we add a JNI call in the native side to destroy
AddToHomescreenManager
after creating an install infobar for WebAPKs.

BUG=692249
==========

to

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we
add a JNI call in the native side to destroy AddToHomescreenManager after
creating an install
infobar for WebAPKs.

BUG=692249
==========

[Xi Han, 2017-03-08 22:58:12]

Description was changed from

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we
add a JNI call in the native side to destroy AddToHomescreenManager after
creating an install
infobar for WebAPKs.

BUG=692249
==========

to

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we add a JNI call in the native side to destroy 
AddToHomescreenManager after creating an install infobar for WebAPKs.

BUG=692249
==========

[Xi Han, 2017-03-08 22:58:29]

The CQ bit was checked by hanxi@chromium.org

[Xi Han, 2017-03-08 22:58:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2738823008/#ps40001
(title: "pkotwicz@'s comments.")

[commit-bot: I haz the power, 2017-03-08 22:58:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:34:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489013909865130,
"parent_rev": "d44db8e60012321c8588641c84baae2a8519b63e", "commit_rev":
"aefa25eb71bb437576f9b0f1b093b9909a211f62"}

[commit-bot: I haz the power, 2017-03-08 23:35:24]

Description was changed from

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we add a JNI call in the native side to destroy 
AddToHomescreenManager after creating an install infobar for WebAPKs.

BUG=692249
==========

to

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we add a JNI call in the native side to destroy 
AddToHomescreenManager after creating an install infobar for WebAPKs.

BUG=692249

Review-Url: https://codereview.chromium.org/2738823008
Cr-Commit-Position: refs/heads/master@{#455594}
Committed:
https://chromium.googlesource.com/chromium/src/+/aefa25eb71bb437576f9b0f1b093...
==========

[commit-bot: I haz the power, 2017-03-08 23:35:25]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aefa25eb71bb437576f9b0f1b093...

[Xi Han, 2017-03-10 18:09:51]

Description was changed from

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we add a JNI call in the native side to destroy 
AddToHomescreenManager after creating an install infobar for WebAPKs.

BUG=692249

Review-Url: https://codereview.chromium.org/2738823008
Cr-Commit-Position: refs/heads/master@{#455594}
Committed:
https://chromium.googlesource.com/chromium/src/+/aefa25eb71bb437576f9b0f1b093...
==========

to

==========
Fix leaking of AddToHomescreenManager for WebAPKs.

Currently, AddToHomescreenManager is never destroyed when installing a WebAPK.
In this CL, we add a JNI call in the native side to destroy 
AddToHomescreenManager after creating an install infobar for WebAPKs.

BUG=688444

Review-Url: https://codereview.chromium.org/2738823008
Cr-Commit-Position: refs/heads/master@{#455594}
Committed:
https://chromium.googlesource.com/chromium/src/+/aefa25eb71bb437576f9b0f1b093...
==========