Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.cc

Issue 2744273002: Fix leaking of AddToHomescreenManager for WebAPKs. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_manager.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.cc b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
index d3eac8c211cf364215675da53d57d0dc2fd8f961..c892d5c9afa4369403231bae137e6b3c57584bac 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_manager.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
@@ -171,14 +171,17 @@ void AddToHomescreenManager::OnDataAvailable(const ShortcutInfo& info,
ShortcutHelper::ShowWebApkInstallInProgressToast();
else
CreateInfoBarForWebApk(info, primary_icon);
+
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_AddToHomescreenManager_onFinished(env, java_ref_);
return;
}
- JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jobject> java_bitmap;
if (!primary_icon.drawsNothing())
java_bitmap = gfx::ConvertToJavaBitmap(&primary_icon);
+ JNIEnv* env = base::android::AttachCurrentThread();
Java_AddToHomescreenManager_onReadyToAdd(env, java_ref_, java_bitmap);
if (add_shortcut_pending_)
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698