Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2734873003: Move FrameHost::m_browserControls to Page (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FrameHost::m_browserControls to Page Move FrameHost::m_browserControls to Page, and reroute the FrameHost::browserControls() getter methods to point to Page's m_browserControls object instead. BUG=691794 Review-Url: https://codereview.chromium.org/2734873003 Cr-Commit-Position: refs/heads/master@{#455385} Committed: https://chromium.googlesource.com/chromium/src/+/d265114438e787fbcefdbe0e081491349a5816b4

Patch Set 1 #

Patch Set 2 : Rebased to 1 off origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 4 chunks +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
sashab
3 years, 9 months ago (2017-03-07 03:47:37 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-07 03:52:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734873003/20001
3 years, 9 months ago (2017-03-08 03:22:44 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 05:29:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d265114438e787fbcefdbe0e0814...

Powered by Google App Engine
This is Rietveld 408576698