Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2734073002: Make BrowserControls take and store a Page instead of a FrameHost (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make BrowserControls take and store a Page instead of a FrameHost This is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2734073002 Cr-Commit-Position: refs/heads/master@{#455362} Committed: https://chromium.googlesource.com/chromium/src/+/d2dc92c168f5010a9eefd1156e09567b23896907

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebased to off origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/frame/BrowserControls.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BrowserControls.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (16 generated)
sashab
3 years, 9 months ago (2017-03-07 03:47:32 UTC) #10
haraken
LGTM
3 years, 9 months ago (2017-03-07 03:52:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734073002/40001
3 years, 9 months ago (2017-03-07 05:33:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379229)
3 years, 9 months ago (2017-03-07 07:21:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734073002/40001
3 years, 9 months ago (2017-03-08 00:39:02 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 03:10:22 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d2dc92c168f5010a9eefd1156e09...

Powered by Google App Engine
This is Rietveld 408576698