Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2734873003: Move FrameHost::m_browserControls to Page (Closed)
Patch Set: Rebased to 1 off origin/master Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 29 matching lines...) Expand all
40 #include "platform/geometry/Region.h" 40 #include "platform/geometry/Region.h"
41 #include "platform/heap/Handle.h" 41 #include "platform/heap/Handle.h"
42 #include "wtf/Forward.h" 42 #include "wtf/Forward.h"
43 #include "wtf/HashSet.h" 43 #include "wtf/HashSet.h"
44 #include "wtf/Noncopyable.h" 44 #include "wtf/Noncopyable.h"
45 #include "wtf/text/WTFString.h" 45 #include "wtf/text/WTFString.h"
46 46
47 namespace blink { 47 namespace blink {
48 48
49 class AutoscrollController; 49 class AutoscrollController;
50 class BrowserControls;
50 class ChromeClient; 51 class ChromeClient;
51 class ClientRectList; 52 class ClientRectList;
52 class ContextMenuClient; 53 class ContextMenuClient;
53 class ContextMenuController; 54 class ContextMenuController;
54 class Document; 55 class Document;
55 class DragCaret; 56 class DragCaret;
56 class DragController; 57 class DragController;
57 class EditorClient; 58 class EditorClient;
58 class FocusController; 59 class FocusController;
59 class Frame; 60 class Frame;
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 179
179 Settings& settings() const { return *m_settings; } 180 Settings& settings() const { return *m_settings; }
180 181
181 UseCounter& useCounter() { return m_useCounter; } 182 UseCounter& useCounter() { return m_useCounter; }
182 Deprecation& deprecation() { return m_deprecation; } 183 Deprecation& deprecation() { return m_deprecation; }
183 HostsUsingFeatures& hostsUsingFeatures() { return m_hostsUsingFeatures; } 184 HostsUsingFeatures& hostsUsingFeatures() { return m_hostsUsingFeatures; }
184 185
185 PageScaleConstraintsSet& pageScaleConstraintsSet(); 186 PageScaleConstraintsSet& pageScaleConstraintsSet();
186 const PageScaleConstraintsSet& pageScaleConstraintsSet() const; 187 const PageScaleConstraintsSet& pageScaleConstraintsSet() const;
187 188
189 BrowserControls& browserControls();
190 const BrowserControls& browserControls() const;
191
188 void setTabKeyCyclesThroughElements(bool b) { 192 void setTabKeyCyclesThroughElements(bool b) {
189 m_tabKeyCyclesThroughElements = b; 193 m_tabKeyCyclesThroughElements = b;
190 } 194 }
191 bool tabKeyCyclesThroughElements() const { 195 bool tabKeyCyclesThroughElements() const {
192 return m_tabKeyCyclesThroughElements; 196 return m_tabKeyCyclesThroughElements;
193 } 197 }
194 198
195 // Suspension is used to implement the "Optionally, pause while waiting for 199 // Suspension is used to implement the "Optionally, pause while waiting for
196 // the user to acknowledge the message" step of simple dialog processing: 200 // the user to acknowledge the message" step of simple dialog processing:
197 // https://html.spec.whatwg.org/multipage/webappapis.html#simple-dialogs 201 // https://html.spec.whatwg.org/multipage/webappapis.html#simple-dialogs
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 Member<PageAnimator> m_animator; 267 Member<PageAnimator> m_animator;
264 const Member<AutoscrollController> m_autoscrollController; 268 const Member<AutoscrollController> m_autoscrollController;
265 Member<ChromeClient> m_chromeClient; 269 Member<ChromeClient> m_chromeClient;
266 const Member<DragCaret> m_dragCaret; 270 const Member<DragCaret> m_dragCaret;
267 const Member<DragController> m_dragController; 271 const Member<DragController> m_dragController;
268 const Member<FocusController> m_focusController; 272 const Member<FocusController> m_focusController;
269 const Member<ContextMenuController> m_contextMenuController; 273 const Member<ContextMenuController> m_contextMenuController;
270 const std::unique_ptr<PageScaleConstraintsSet> m_pageScaleConstraintsSet; 274 const std::unique_ptr<PageScaleConstraintsSet> m_pageScaleConstraintsSet;
271 const Member<PointerLockController> m_pointerLockController; 275 const Member<PointerLockController> m_pointerLockController;
272 Member<ScrollingCoordinator> m_scrollingCoordinator; 276 Member<ScrollingCoordinator> m_scrollingCoordinator;
277 const Member<BrowserControls> m_browserControls;
273 278
274 // Typically, the main frame and Page should both be owned by the embedder, 279 // Typically, the main frame and Page should both be owned by the embedder,
275 // which must call Page::willBeDestroyed() prior to destroying Page. This 280 // which must call Page::willBeDestroyed() prior to destroying Page. This
276 // call detaches the main frame and clears this pointer, thus ensuring that 281 // call detaches the main frame and clears this pointer, thus ensuring that
277 // this field only references a live main frame. 282 // this field only references a live main frame.
278 // 283 //
279 // However, there are several locations (InspectorOverlay, SVGImage, and 284 // However, there are several locations (InspectorOverlay, SVGImage, and
280 // WebPagePopupImpl) which don't hold a reference to the main frame at all 285 // WebPagePopupImpl) which don't hold a reference to the main frame at all
281 // after creating it. These are still safe because they always create a 286 // after creating it. These are still safe because they always create a
282 // Frame with a FrameView. FrameView and Frame hold references to each 287 // Frame with a FrameView. FrameView and Frame hold references to each
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 // Page. 325 // Page.
321 // FIXME: Most of the members of Page should move onto FrameHost. 326 // FIXME: Most of the members of Page should move onto FrameHost.
322 Member<FrameHost> m_frameHost; 327 Member<FrameHost> m_frameHost;
323 }; 328 };
324 329
325 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>; 330 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>;
326 331
327 } // namespace blink 332 } // namespace blink
328 333
329 #endif // Page_h 334 #endif // Page_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.cpp ('k') | third_party/WebKit/Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698