Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2737703002: Remove FrameHost::browserControls() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kenneth.christiansen, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameHost::browserControls() Remove FrameHost::browserControls(), and redirect all calls to Page::browserControls(). BUG=691794 Review-Url: https://codereview.chromium.org/2737703002 Cr-Commit-Position: refs/heads/master@{#455650} Committed: https://chromium.googlesource.com/chromium/src/+/4344f497cf240b361ccc9499ed965aede2f9c49d

Patch Set 1 #

Patch Set 2 : Rebase to 2 off origin/master #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
sashab
3 years, 9 months ago (2017-03-08 03:48:43 UTC) #10
joelhockey
lgtm
3 years, 9 months ago (2017-03-08 04:03:57 UTC) #11
sashab
3 years, 9 months ago (2017-03-08 04:12:32 UTC) #13
haraken
LGTM
3 years, 9 months ago (2017-03-08 06:06:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737703002/40001
3 years, 9 months ago (2017-03-09 01:03:57 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/336770)
3 years, 9 months ago (2017-03-09 01:54:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737703002/40001
3 years, 9 months ago (2017-03-09 01:58:58 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 02:54:31 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4344f497cf240b361ccc9499ed96...

Powered by Google App Engine
This is Rietveld 408576698