Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameHost.cpp

Issue 2734873003: Move FrameHost::m_browserControls to Page (Closed)
Patch Set: Rebased to 1 off origin/master Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 12 matching lines...) Expand all
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "core/frame/FrameHost.h" 31 #include "core/frame/FrameHost.h"
32 32
33 #include "core/frame/BrowserControls.h"
34 #include "core/frame/EventHandlerRegistry.h" 33 #include "core/frame/EventHandlerRegistry.h"
35 #include "core/frame/FrameView.h" 34 #include "core/frame/FrameView.h"
36 #include "core/frame/VisualViewport.h" 35 #include "core/frame/VisualViewport.h"
37 #include "core/inspector/ConsoleMessageStorage.h" 36 #include "core/inspector/ConsoleMessageStorage.h"
38 #include "core/page/Page.h" 37 #include "core/page/Page.h"
39 #include "core/page/scrolling/OverscrollController.h" 38 #include "core/page/scrolling/OverscrollController.h"
40 #include "core/page/scrolling/TopDocumentRootScrollerController.h" 39 #include "core/page/scrolling/TopDocumentRootScrollerController.h"
41 #include "public/platform/Platform.h" 40 #include "public/platform/Platform.h"
42 #include "public/platform/WebScheduler.h" 41 #include "public/platform/WebScheduler.h"
43 42
44 namespace blink { 43 namespace blink {
45 44
46 FrameHost* FrameHost::create(Page& page) { 45 FrameHost* FrameHost::create(Page& page) {
47 return new FrameHost(page); 46 return new FrameHost(page);
48 } 47 }
49 48
50 FrameHost::FrameHost(Page& page) 49 FrameHost::FrameHost(Page& page)
51 : m_page(&page), 50 : m_page(&page),
52 m_browserControls(BrowserControls::create(page)),
53 m_visualViewport(VisualViewport::create(*this)), 51 m_visualViewport(VisualViewport::create(*this)),
54 m_overscrollController( 52 m_overscrollController(
55 OverscrollController::create(*m_visualViewport, 53 OverscrollController::create(*m_visualViewport,
56 m_page->chromeClient())), 54 m_page->chromeClient())),
57 m_eventHandlerRegistry(new EventHandlerRegistry(*this)), 55 m_eventHandlerRegistry(new EventHandlerRegistry(*this)),
58 m_consoleMessageStorage(new ConsoleMessageStorage()), 56 m_consoleMessageStorage(new ConsoleMessageStorage()),
59 m_globalRootScrollerController( 57 m_globalRootScrollerController(
60 TopDocumentRootScrollerController::create(*this)), 58 TopDocumentRootScrollerController::create(*this)),
61 m_subframeCount(0) {} 59 m_subframeCount(0) {}
62 60
63 // Explicitly in the .cpp to avoid default constructor in .h 61 // Explicitly in the .cpp to avoid default constructor in .h
64 FrameHost::~FrameHost() {} 62 FrameHost::~FrameHost() {}
65 63
66 Page& FrameHost::page() { 64 Page& FrameHost::page() {
67 return *m_page; 65 return *m_page;
68 } 66 }
69 67
70 const Page& FrameHost::page() const { 68 const Page& FrameHost::page() const {
71 return *m_page; 69 return *m_page;
72 } 70 }
73 71
74 BrowserControls& FrameHost::browserControls() { 72 BrowserControls& FrameHost::browserControls() {
75 return *m_browserControls; 73 return m_page->browserControls();
76 } 74 }
77 75
78 const BrowserControls& FrameHost::browserControls() const { 76 const BrowserControls& FrameHost::browserControls() const {
79 return *m_browserControls; 77 return m_page->browserControls();
80 } 78 }
81 79
82 OverscrollController& FrameHost::overscrollController() { 80 OverscrollController& FrameHost::overscrollController() {
83 return *m_overscrollController; 81 return *m_overscrollController;
84 } 82 }
85 83
86 const OverscrollController& FrameHost::overscrollController() const { 84 const OverscrollController& FrameHost::overscrollController() const {
87 return *m_overscrollController; 85 return *m_overscrollController;
88 } 86 }
89 87
(...skipping 29 matching lines...) Expand all
119 return *m_consoleMessageStorage; 117 return *m_consoleMessageStorage;
120 } 118 }
121 119
122 TopDocumentRootScrollerController& FrameHost::globalRootScrollerController() 120 TopDocumentRootScrollerController& FrameHost::globalRootScrollerController()
123 const { 121 const {
124 return *m_globalRootScrollerController; 122 return *m_globalRootScrollerController;
125 } 123 }
126 124
127 DEFINE_TRACE(FrameHost) { 125 DEFINE_TRACE(FrameHost) {
128 visitor->trace(m_page); 126 visitor->trace(m_page);
129 visitor->trace(m_browserControls);
130 visitor->trace(m_visualViewport); 127 visitor->trace(m_visualViewport);
131 visitor->trace(m_overscrollController); 128 visitor->trace(m_overscrollController);
132 visitor->trace(m_eventHandlerRegistry); 129 visitor->trace(m_eventHandlerRegistry);
133 visitor->trace(m_consoleMessageStorage); 130 visitor->trace(m_consoleMessageStorage);
134 visitor->trace(m_globalRootScrollerController); 131 visitor->trace(m_globalRootScrollerController);
135 } 132 }
136 133
137 #if DCHECK_IS_ON() 134 #if DCHECK_IS_ON()
138 void checkFrameCountConsistency(int expectedFrameCount, Frame* frame) { 135 void checkFrameCountConsistency(int expectedFrameCount, Frame* frame) {
139 ASSERT(expectedFrameCount >= 0); 136 ASSERT(expectedFrameCount >= 0);
140 137
141 int actualFrameCount = 0; 138 int actualFrameCount = 0;
142 for (; frame; frame = frame->tree().traverseNext()) 139 for (; frame; frame = frame->tree().traverseNext())
143 ++actualFrameCount; 140 ++actualFrameCount;
144 141
145 ASSERT(expectedFrameCount == actualFrameCount); 142 ASSERT(expectedFrameCount == actualFrameCount);
146 } 143 }
147 #endif 144 #endif
148 145
149 int FrameHost::subframeCount() const { 146 int FrameHost::subframeCount() const {
150 #if DCHECK_IS_ON() 147 #if DCHECK_IS_ON()
151 checkFrameCountConsistency(m_subframeCount + 1, m_page->mainFrame()); 148 checkFrameCountConsistency(m_subframeCount + 1, m_page->mainFrame());
152 #endif 149 #endif
153 return m_subframeCount; 150 return m_subframeCount;
154 } 151 }
155 152
156 } // namespace blink 153 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.h ('k') | third_party/WebKit/Source/core/page/Page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698