Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2734873003: Move FrameHost::m_browserControls to Page (Closed)
Patch Set: Rebased to 1 off origin/master Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All
3 * Rights Reserved. 3 * Rights Reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 12 matching lines...) Expand all
23 23
24 #include "bindings/core/v8/ScriptController.h" 24 #include "bindings/core/v8/ScriptController.h"
25 #include "core/css/resolver/ViewportStyleResolver.h" 25 #include "core/css/resolver/ViewportStyleResolver.h"
26 #include "core/dom/ClientRectList.h" 26 #include "core/dom/ClientRectList.h"
27 #include "core/dom/StyleChangeReason.h" 27 #include "core/dom/StyleChangeReason.h"
28 #include "core/dom/StyleEngine.h" 28 #include "core/dom/StyleEngine.h"
29 #include "core/dom/VisitedLinkState.h" 29 #include "core/dom/VisitedLinkState.h"
30 #include "core/editing/DragCaret.h" 30 #include "core/editing/DragCaret.h"
31 #include "core/editing/markers/DocumentMarkerController.h" 31 #include "core/editing/markers/DocumentMarkerController.h"
32 #include "core/events/Event.h" 32 #include "core/events/Event.h"
33 #include "core/frame/BrowserControls.h"
33 #include "core/frame/DOMTimer.h" 34 #include "core/frame/DOMTimer.h"
34 #include "core/frame/FrameConsole.h" 35 #include "core/frame/FrameConsole.h"
35 #include "core/frame/FrameHost.h" 36 #include "core/frame/FrameHost.h"
36 #include "core/frame/FrameView.h" 37 #include "core/frame/FrameView.h"
37 #include "core/frame/PageScaleConstraints.h" 38 #include "core/frame/PageScaleConstraints.h"
38 #include "core/frame/PageScaleConstraintsSet.h" 39 #include "core/frame/PageScaleConstraintsSet.h"
39 #include "core/frame/RemoteFrame.h" 40 #include "core/frame/RemoteFrame.h"
40 #include "core/frame/RemoteFrameView.h" 41 #include "core/frame/RemoteFrameView.h"
41 #include "core/frame/Settings.h" 42 #include "core/frame/Settings.h"
42 #include "core/frame/VisualViewport.h" 43 #include "core/frame/VisualViewport.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 m_animator(PageAnimator::create(*this)), 97 m_animator(PageAnimator::create(*this)),
97 m_autoscrollController(AutoscrollController::create(*this)), 98 m_autoscrollController(AutoscrollController::create(*this)),
98 m_chromeClient(pageClients.chromeClient), 99 m_chromeClient(pageClients.chromeClient),
99 m_dragCaret(DragCaret::create()), 100 m_dragCaret(DragCaret::create()),
100 m_dragController(DragController::create(this)), 101 m_dragController(DragController::create(this)),
101 m_focusController(FocusController::create(this)), 102 m_focusController(FocusController::create(this)),
102 m_contextMenuController( 103 m_contextMenuController(
103 ContextMenuController::create(this, pageClients.contextMenuClient)), 104 ContextMenuController::create(this, pageClients.contextMenuClient)),
104 m_pageScaleConstraintsSet(PageScaleConstraintsSet::create()), 105 m_pageScaleConstraintsSet(PageScaleConstraintsSet::create()),
105 m_pointerLockController(PointerLockController::create(this)), 106 m_pointerLockController(PointerLockController::create(this)),
107 m_browserControls(BrowserControls::create(*this)),
106 m_mainFrame(nullptr), 108 m_mainFrame(nullptr),
107 m_editorClient(pageClients.editorClient), 109 m_editorClient(pageClients.editorClient),
108 m_spellCheckerClient(pageClients.spellCheckerClient), 110 m_spellCheckerClient(pageClients.spellCheckerClient),
109 m_useCounter(pageClients.chromeClient && 111 m_useCounter(pageClients.chromeClient &&
110 pageClients.chromeClient->isSVGImageChromeClient() 112 pageClients.chromeClient->isSVGImageChromeClient()
111 ? UseCounter::SVGImageContext 113 ? UseCounter::SVGImageContext
112 : UseCounter::DefaultContext), 114 : UseCounter::DefaultContext),
113 m_openedByDOM(false), 115 m_openedByDOM(false),
114 m_tabKeyCyclesThroughElements(true), 116 m_tabKeyCyclesThroughElements(true),
115 m_suspended(false), 117 m_suspended(false),
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 } 156 }
155 157
156 PageScaleConstraintsSet& Page::pageScaleConstraintsSet() { 158 PageScaleConstraintsSet& Page::pageScaleConstraintsSet() {
157 return *m_pageScaleConstraintsSet; 159 return *m_pageScaleConstraintsSet;
158 } 160 }
159 161
160 const PageScaleConstraintsSet& Page::pageScaleConstraintsSet() const { 162 const PageScaleConstraintsSet& Page::pageScaleConstraintsSet() const {
161 return *m_pageScaleConstraintsSet; 163 return *m_pageScaleConstraintsSet;
162 } 164 }
163 165
166 BrowserControls& Page::browserControls() {
167 return *m_browserControls;
168 }
169
170 const BrowserControls& Page::browserControls() const {
171 return *m_browserControls;
172 }
173
164 ClientRectList* Page::nonFastScrollableRects(const LocalFrame* frame) { 174 ClientRectList* Page::nonFastScrollableRects(const LocalFrame* frame) {
165 DisableCompositingQueryAsserts disabler; 175 DisableCompositingQueryAsserts disabler;
166 if (ScrollingCoordinator* scrollingCoordinator = 176 if (ScrollingCoordinator* scrollingCoordinator =
167 this->scrollingCoordinator()) { 177 this->scrollingCoordinator()) {
168 // Hits in compositing/iframes/iframe-composited-scrolling.html 178 // Hits in compositing/iframes/iframe-composited-scrolling.html
169 scrollingCoordinator->updateAfterCompositingChangeIfNeeded(); 179 scrollingCoordinator->updateAfterCompositingChangeIfNeeded();
170 } 180 }
171 181
172 GraphicsLayer* layer = 182 GraphicsLayer* layer =
173 frame->view()->layoutViewportScrollableArea()->layerForScrolling(); 183 frame->view()->layoutViewportScrollableArea()->layerForScrolling();
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 DEFINE_TRACE(Page) { 542 DEFINE_TRACE(Page) {
533 visitor->trace(m_animator); 543 visitor->trace(m_animator);
534 visitor->trace(m_autoscrollController); 544 visitor->trace(m_autoscrollController);
535 visitor->trace(m_chromeClient); 545 visitor->trace(m_chromeClient);
536 visitor->trace(m_dragCaret); 546 visitor->trace(m_dragCaret);
537 visitor->trace(m_dragController); 547 visitor->trace(m_dragController);
538 visitor->trace(m_focusController); 548 visitor->trace(m_focusController);
539 visitor->trace(m_contextMenuController); 549 visitor->trace(m_contextMenuController);
540 visitor->trace(m_pointerLockController); 550 visitor->trace(m_pointerLockController);
541 visitor->trace(m_scrollingCoordinator); 551 visitor->trace(m_scrollingCoordinator);
552 visitor->trace(m_browserControls);
542 visitor->trace(m_mainFrame); 553 visitor->trace(m_mainFrame);
543 visitor->trace(m_validationMessageClient); 554 visitor->trace(m_validationMessageClient);
544 visitor->trace(m_useCounter); 555 visitor->trace(m_useCounter);
545 visitor->trace(m_frameHost); 556 visitor->trace(m_frameHost);
546 Supplementable<Page>::trace(visitor); 557 Supplementable<Page>::trace(visitor);
547 PageVisibilityNotifier::trace(visitor); 558 PageVisibilityNotifier::trace(visitor);
548 } 559 }
549 560
550 void Page::layerTreeViewInitialized(WebLayerTreeView& layerTreeView, 561 void Page::layerTreeViewInitialized(WebLayerTreeView& layerTreeView,
551 FrameView* view) { 562 FrameView* view) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 : chromeClient(nullptr), 594 : chromeClient(nullptr),
584 contextMenuClient(nullptr), 595 contextMenuClient(nullptr),
585 editorClient(nullptr), 596 editorClient(nullptr),
586 spellCheckerClient(nullptr) {} 597 spellCheckerClient(nullptr) {}
587 598
588 Page::PageClients::~PageClients() {} 599 Page::PageClients::~PageClients() {}
589 600
590 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 601 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
591 602
592 } // namespace blink 603 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698