Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

s/IsSamePage/IsSameDocument for NavigationContext. This mirrors a change for all other platforms: https://codereview.chromium.org/2716493004/ BUG=695189 Review-Url: https://codereview.chromium.org/2734293002 Cr-Commit-Position: refs/heads/master@{#456483} Committed: https://chromium.googlesource.com/chromium/src/+/af71322a182d469fc0acede81218fdeb19d5ecb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M components/translate/ios/browser/language_detection_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/public/web_state/navigation_context.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/public/web_state/web_state_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.mm View 5 chunks +7 lines, -7 lines 0 comments Download
M ios/web/web_state/navigation_context_impl_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Eugene But (OOO till 7-30)
Sylvain?
3 years, 9 months ago (2017-03-09 23:46:39 UTC) #7
sdefresne
lgtm
3 years, 9 months ago (2017-03-13 08:43:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734293002/1
3 years, 9 months ago (2017-03-13 20:36:12 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 21:11:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af71322a182d469fc0acede81218...

Powered by Google App Engine
This is Rietveld 408576698