Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: ios/web/web_state/navigation_context_impl.mm

Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/navigation_context_impl.h ('k') | ios/web/web_state/navigation_context_impl_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/navigation_context_impl.mm
diff --git a/ios/web/web_state/navigation_context_impl.mm b/ios/web/web_state/navigation_context_impl.mm
index fdbe1fb8142de62c20d8b716b61e4523cd4865dc..5fc2a36d7a483c1523a224531a83bae451cf6a56 100644
--- a/ios/web/web_state/navigation_context_impl.mm
+++ b/ios/web/web_state/navigation_context_impl.mm
@@ -13,7 +13,7 @@ std::unique_ptr<NavigationContext>
NavigationContextImpl::CreateNavigationContext(WebState* web_state,
const GURL& url) {
std::unique_ptr<NavigationContext> resut(new NavigationContextImpl(
- web_state, url, false /* is_same_page */, false /* is_error_page */));
+ web_state, url, false /* is_same_document */, false /* is_error_page */));
return resut;
}
@@ -22,7 +22,7 @@ std::unique_ptr<NavigationContext>
NavigationContextImpl::CreateSamePageNavigationContext(WebState* web_state,
const GURL& url) {
std::unique_ptr<NavigationContext> result(new NavigationContextImpl(
- web_state, url, true /* is_same_page */, false /* is_error_page */));
+ web_state, url, true /* is_same_document */, false /* is_error_page */));
return result;
}
@@ -31,7 +31,7 @@ std::unique_ptr<NavigationContext>
NavigationContextImpl::CreateErrorPageNavigationContext(WebState* web_state,
const GURL& url) {
std::unique_ptr<NavigationContext> result(new NavigationContextImpl(
- web_state, url, false /* is_same_page */, true /* is_error_page */));
+ web_state, url, false /* is_same_document */, true /* is_error_page */));
return result;
}
@@ -43,8 +43,8 @@ const GURL& NavigationContextImpl::GetUrl() const {
return url_;
}
-bool NavigationContextImpl::IsSamePage() const {
- return is_same_page_;
+bool NavigationContextImpl::IsSameDocument() const {
+ return is_same_document_;
}
bool NavigationContextImpl::IsErrorPage() const {
@@ -53,11 +53,11 @@ bool NavigationContextImpl::IsErrorPage() const {
NavigationContextImpl::NavigationContextImpl(WebState* web_state,
const GURL& url,
- bool is_same_page,
+ bool is_same_document,
bool is_error_page)
: web_state_(web_state),
url_(url),
- is_same_page_(is_same_page),
+ is_same_document_(is_same_document),
is_error_page_(is_error_page) {}
NavigationContextImpl::~NavigationContextImpl() = default;
« no previous file with comments | « ios/web/web_state/navigation_context_impl.h ('k') | ios/web/web_state/navigation_context_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698