ios/web/web_state/navigation_context_impl_unittest.mm - Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/navigation_context_impl_unittest.mm

Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/navigation_context_impl_unittest.mm

diff --git a/ios/web/web_state/navigation_context_impl_unittest.mm b/ios/web/web_state/navigation_context_impl_unittest.mm

index b209afcc2fcd5d834c20fc1b2ad9a9cce7d6c152..c9c8a87b830b700947b7b9f84c6ce6630455784b 100644

--- a/ios/web/web_state/navigation_context_impl_unittest.mm

+++ b/ios/web/web_state/navigation_context_impl_unittest.mm

@@ -27,7 +27,7 @@ TEST_F(NavigationContextImplTest, NavigationContext) {

EXPECT_EQ(&web_state_, context->GetWebState());

EXPECT_EQ(url_, context->GetUrl());

- EXPECT_FALSE(context->IsSamePage());

+ EXPECT_FALSE(context->IsSameDocument());

EXPECT_FALSE(context->IsErrorPage());

}

@@ -39,7 +39,7 @@ TEST_F(NavigationContextImplTest, SamePageNavigationContext) {

EXPECT_EQ(&web_state_, context->GetWebState());

EXPECT_EQ(url_, context->GetUrl());

- EXPECT_TRUE(context->IsSamePage());

+ EXPECT_TRUE(context->IsSameDocument());

EXPECT_FALSE(context->IsErrorPage());

}

@@ -52,7 +52,7 @@ TEST_F(NavigationContextImplTest, ErrorPageNavigationContext) {

EXPECT_EQ(&web_state_, context->GetWebState());

EXPECT_EQ(url_, context->GetUrl());

- EXPECT_FALSE(context->IsSamePage());

+ EXPECT_FALSE(context->IsSameDocument());

EXPECT_TRUE(context->IsErrorPage());

}