ios/chrome/browser/tabs/tab.mm - Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab.mm

diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm

index 2ba5b8ccdf82b2b7cf0a995426df689aac758a69..76f4d8cd1eac7566de641ee486ae674462e5902a 100644

--- a/ios/chrome/browser/tabs/tab.mm

+++ b/ios/chrome/browser/tabs/tab.mm

@@ -1394,7 +1394,7 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,

- (void)webState:(web::WebState*)webState

didFinishNavigation:(web::NavigationContext*)navigation {

- if (navigation->IsSamePage()) {

+ if (navigation->IsSameDocument()) {

auto* faviconDriver = favicon::WebFaviconDriver::FromWebState(webState);

if (faviconDriver) {

// Fetch the favicon for the new URL.