ios/web/web_state/navigation_context_impl.h - Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/navigation_context_impl.h

Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/navigation_context_impl.h

diff --git a/ios/web/web_state/navigation_context_impl.h b/ios/web/web_state/navigation_context_impl.h

index 11b86c1e990ea724fc5314f9ebd5b1a297feffd2..b7bb18eacd21bd5d59baac8482d1d177d68a4791 100644

--- a/ios/web/web_state/navigation_context_impl.h

+++ b/ios/web/web_state/navigation_context_impl.h

@@ -34,7 +34,7 @@ class NavigationContextImpl : public NavigationContext {

// NavigationContext overrides:

WebState* GetWebState() override;

const GURL& GetUrl() const override;

- bool IsSamePage() const override;

+ bool IsSameDocument() const override;

bool IsErrorPage() const override;

private:

@@ -46,7 +46,7 @@ class NavigationContextImpl : public NavigationContext {

WebState* web_state_ = nullptr;

GURL url_;

- bool is_same_page_ = false;

+ bool is_same_document_ = false;

bool is_error_page_ = false;

DISALLOW_COPY_AND_ASSIGN(NavigationContextImpl);