Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/web_state/navigation_callbacks_inttest.mm

Issue 2734293002: s/IsSamePage/IsSameDocument for NavigationContext. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/web_state/web_state_observer.h ('k') | ios/web/web_state/navigation_context_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/navigation_callbacks_inttest.mm
diff --git a/ios/web/web_state/navigation_callbacks_inttest.mm b/ios/web/web_state/navigation_callbacks_inttest.mm
index 4fa3001563237b6ce56cd4aca0f39c30c0fb3a99..4a9856804f77ccaf78a686c588fa89eceb3e080f 100644
--- a/ios/web/web_state/navigation_callbacks_inttest.mm
+++ b/ios/web/web_state/navigation_callbacks_inttest.mm
@@ -29,7 +29,7 @@ ACTION_P2(VerifyNewPageContext, web_state, url) {
ASSERT_TRUE(context);
EXPECT_EQ(web_state, context->GetWebState());
EXPECT_EQ(url, context->GetUrl());
- EXPECT_FALSE(context->IsSamePage());
+ EXPECT_FALSE(context->IsSameDocument());
EXPECT_FALSE(context->IsErrorPage());
NavigationManager* navigation_manager = web_state->GetNavigationManager();
NavigationItem* item = navigation_manager->GetLastCommittedItem();
@@ -44,7 +44,7 @@ ACTION_P2(VerifySamePageContext, web_state, url) {
ASSERT_TRUE(context);
EXPECT_EQ(web_state, context->GetWebState());
EXPECT_EQ(url, context->GetUrl());
- EXPECT_TRUE(context->IsSamePage());
+ EXPECT_TRUE(context->IsSameDocument());
EXPECT_FALSE(context->IsErrorPage());
NavigationManager* navigation_manager = web_state->GetNavigationManager();
NavigationItem* item = navigation_manager->GetLastCommittedItem();
« no previous file with comments | « ios/web/public/web_state/web_state_observer.h ('k') | ios/web/web_state/navigation_context_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698