Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted. (Closed)

Created:
3 years, 9 months ago by ikilpatrick
Modified:
3 years, 9 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Switch NGConstraintSpace to being RefCounted. This shouldn't have any behaviour changes. BUG=635619 Review-Url: https://codereview.chromium.org/2724133003 Cr-Commit-Position: refs/heads/master@{#454331} Committed: https://chromium.googlesource.com/chromium/src/+/4be772fa4ee0cb2bf699f27469db19b22866a7b0

Patch Set 1 #

Patch Set 2 : moar. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -157 lines) Patch
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 2 chunks +3 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 34 chunks +63 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_floating_object.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 9 chunks +21 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
ikilpatrick
3 years, 9 months ago (2017-03-02 17:19:12 UTC) #3
ikilpatrick
https://codereview.chromium.org/2724133003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h (right): https://codereview.chromium.org/2724133003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h#newcode81 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:81: NGConstraintSpace* constraint_space_; Just a pointer as STACK_ALLOCATED(). Going to ...
3 years, 9 months ago (2017-03-02 17:20:15 UTC) #4
cbiesinger
lgtm
3 years, 9 months ago (2017-03-02 18:06:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724133003/20001
3 years, 9 months ago (2017-03-02 18:53:21 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 19:21:08 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4be772fa4ee0cb2bf699f27469db...

Powered by Google App Engine
This is Rietveld 408576698