third_party/WebKit/Source/core/layout/ng/ng_line_builder.h - Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted. (Closed)

Patch Set: moar. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

index f8569c1538ec34d820565bb7d18ac3c78b9467fe..2727f04d0ef863aef24f7b23b2211d5867ced652 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

@@ -140,7 +140,7 @@ class CORE_EXPORT NGLineBuilder final {

LineBoxData*);

Persistent<NGInlineNode> inline_box_;

- Persistent<const NGConstraintSpace> constraint_space_;

+ const NGConstraintSpace* constraint_space_; // Not owned as STACK_ALLOCATED.

Vector<RefPtr<NGPhysicalFragment>, 32> fragments_;

Vector<NGLogicalOffset, 32> offsets_;

Vector<LineBoxData, 32> line_box_data_list_;