third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc - Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted. (Closed)

Patch Set: moar. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

index d74585bc488d636a28662d663736b216212afebc..acdfb59f876020c7ec45bc0c557764f086959855 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

@@ -82,10 +82,10 @@ class NGAbsoluteUtilsTest : public ::testing::Test {

RefPtr<ComputedStyle> style_;

NGLogicalSize container_size_;

- Persistent<NGConstraintSpace> ltr_space_;

- Persistent<NGConstraintSpace> rtl_space_;

- Persistent<NGConstraintSpace> vertical_lr_space_;

- Persistent<NGConstraintSpace> vertical_rl_space_;

+ RefPtr<NGConstraintSpace> ltr_space_;

+ RefPtr<NGConstraintSpace> rtl_space_;

+ RefPtr<NGConstraintSpace> vertical_lr_space_;

+ RefPtr<NGConstraintSpace> vertical_rl_space_;

};

TEST_F(NGAbsoluteUtilsTest, Horizontal) {