Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted. (Closed)
Patch Set: moar. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
index 9136e47128b923d8d99e8dffebf60fd544991969..de696c937002713b6405cd1329b75fa6fff0ae34 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
@@ -8,8 +8,8 @@
#include "core/CoreExport.h"
#include "core/layout/ng/ng_units.h"
#include "core/layout/ng/ng_writing_mode.h"
-#include "platform/heap/Handle.h"
#include "wtf/Optional.h"
+#include "wtf/RefCounted.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -27,11 +27,11 @@ enum NGFragmentationType {
// The NGConstraintSpace represents a set of constraints and available space
// which a layout algorithm may produce a NGFragment within.
class CORE_EXPORT NGConstraintSpace final
- : public GarbageCollectedFinalized<NGConstraintSpace> {
+ : public RefCounted<NGConstraintSpace> {
public:
// This should live on NGBlockNode or another layout bridge and probably take
// a root NGConstraintSpace.
- static NGConstraintSpace* CreateFromLayoutObject(const LayoutBox&);
+ static RefPtr<NGConstraintSpace> CreateFromLayoutObject(const LayoutBox&);
const std::shared_ptr<NGExclusions>& Exclusions() const {
return exclusions_;
@@ -121,8 +121,6 @@ class CORE_EXPORT NGConstraintSpace final
return clearance_offset_;
}
- DEFINE_INLINE_VIRTUAL_TRACE() {}
-
String ToString() const;
private:

Powered by Google App Engine
This is Rietveld 408576698