third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc - Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted. (Closed)

Patch Set: moar. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

index 1f3c4d01136612d5d0e3b0ead30f3940b26eb9aa..cf99563b25553911c110a83b8f17ce39cc5e38e8 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

@@ -51,7 +51,7 @@ NGConstraintSpace::NGConstraintSpace(

exclusions_(exclusions),

clearance_offset_(clearance_offset) {}

-NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(

+RefPtr<NGConstraintSpace> NGConstraintSpace::CreateFromLayoutObject(

const LayoutBox& box) {

auto writing_mode = FromPlatformWritingMode(box.styleRef().getWritingMode());

bool parallel_containing_block = IsParallelWritingMode(