Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_floating_object.h

Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted. (Closed)
Patch Set: moar. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h b/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
index 0792952776aee501b38b18676a6f1c659ff26bf1..bfe7c0d32c8334da3991b55c59808b9469691065 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_floating_object.h
@@ -38,11 +38,11 @@ struct CORE_EXPORT NGFloatingObject
RefPtr<NGPhysicalFragment> fragment;
// TODO(glebl): Constraint space should be const here.
- Member<NGConstraintSpace> space;
+ RefPtr<NGConstraintSpace> space;
// Parent space is used so we can calculate the inline offset relative to
// the original parent of this float.
- Member<const NGConstraintSpace> original_parent_space;
+ RefPtr<const NGConstraintSpace> original_parent_space;
Member<NGBlockNode> node;
NGExclusion::Type exclusion_type;
EClear clear_type;
@@ -58,8 +58,6 @@ struct CORE_EXPORT NGFloatingObject
LayoutUnit left_offset;
DEFINE_INLINE_TRACE() {
- visitor->trace(space);
- visitor->trace(original_parent_space);
visitor->trace(node);
}
};

Powered by Google App Engine
This is Rietveld 408576698