[V8] Rename SIMD Create methods and add initialization operators.

[V8] Rename SIMD Create methods and add initialization operators.

- Renames Create ops to Splat.
- Adds machine operators to initialize all SIMD machine types.
  Boolean vector types may need initialization, so provide zero
  operators.

LOG=N
BUG=v8:4124, 695330
Review-Url: https://codereview.chromium.org/2719483002
Cr-Commit-Position: refs/heads/master@{#43430}
Committed: https://chromium.googlesource.com/v8/v8/+/d126e3fc5561a774cf5e4c70441ac585b2131e74

[bbudge, 2017-02-24 13:18:57]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 13:19:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-02-24 13:23:46]

bbudge@chromium.org changed reviewers:
+ aseemgarg@chromium.org, bmeurer@chromium.org, gdeepti@chromium.org

[bbudge, 2017-02-24 13:23:47]

Benedikt for overall review
Aseem for changes to SIMD scalar lowering
Deepti for changes to SIMD initialization and x64

https://codereview.chromium.org/2719483002/diff/1/src/compiler/simd-scalar-lo...
File src/compiler/simd-scalar-lowering.cc (right):

https://codereview.chromium.org/2719483002/diff/1/src/compiler/simd-scalar-lo...
src/compiler/simd-scalar-lowering.cc:395: rep_node[i] = node->InputAt(0);
Aseem, I wasn't sure what to do here. This seemed like the safest change.

[commit-bot: I haz the power, 2017-02-24 13:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 13:41:22]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-02-24 14:18:11]

lgtm with question.

https://codereview.chromium.org/2719483002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2719483002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:278: return builder_->Simd1x4Zero();
Would it be better to have these fall through to Simd128Zero, here as well as
for the visitor methods in the selector till kSimdMaskRegisters for one of the
platforms are enabled?

[bbudge, 2017-02-24 18:33:51]

https://codereview.chromium.org/2719483002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2719483002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:278: return builder_->Simd1x4Zero();
On 2017/02/24 14:18:11, gdeepti wrote:
> Would it be better to have these fall through to Simd128Zero, here as well as
> for the visitor methods in the selector till kSimdMaskRegisters for one of the
> platforms are enabled? 

It does seem like a lot of trouble to support a scenario that may be far in the
future. I finally decided to plumb these through the platform independent part
of Turbofan now so it won't be so hard for someone else to add support for AVX
mask registers later. For the platforms that natively support SIMD, the visitors
do map these to the same machine instruction.

[Benedikt Meurer, 2017-02-24 18:40:13]

LGTM, thanks.

[bbudge, 2017-02-24 22:27:05]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:27:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 22:29:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:29:57]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35484)

[bbudge, 2017-02-24 22:31:10]

bbudge@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bbudge, 2017-02-24 22:31:11]

+Brad for /wasm

[bradnelson, 2017-02-24 23:26:46]

lgtm

[bbudge, 2017-02-25 15:15:34]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-02-25 15:15:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 15:41:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488035734800310, "parent_rev":
"4310cd02d2160b1457baed81a2f40063eb264a21", "commit_rev":
"d126e3fc5561a774cf5e4c70441ac585b2131e74"}

[commit-bot: I haz the power, 2017-02-25 15:41:32]

Description was changed from

==========
[V8] Rename SIMD Create methods and add initialization operators.

- Renames Create ops to Splat.
- Adds machine operators to initialize all SIMD machine types.
  Boolean vector types may need initialization, so provide zero
  operators.

LOG=N
BUG=v8:4124,695330
==========

to

==========
[V8] Rename SIMD Create methods and add initialization operators.

- Renames Create ops to Splat.
- Adds machine operators to initialize all SIMD machine types.
  Boolean vector types may need initialization, so provide zero
  operators.

LOG=N
BUG=v8:4124,695330

Review-Url: https://codereview.chromium.org/2719483002
Cr-Commit-Position: refs/heads/master@{#43430}
Committed:
https://chromium.googlesource.com/v8/v8/+/d126e3fc5561a774cf5e4c70441ac585b21...
==========

[commit-bot: I haz the power, 2017-02-25 15:41:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d126e3fc5561a774cf5e4c70441ac585b21...