Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 2719483002: [V8] Rename SIMD Create methods and add initialization operators. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/arm/instruction-selector-arm.cc
diff --git a/src/compiler/arm/instruction-selector-arm.cc b/src/compiler/arm/instruction-selector-arm.cc
index 0cffff7a1cf63d40dd9a9ff48af79211bdbed264..a0420eafb9e74a092a3a9b36e0d10676f45705e3 100644
--- a/src/compiler/arm/instruction-selector-arm.cc
+++ b/src/compiler/arm/instruction-selector-arm.cc
@@ -2192,6 +2192,12 @@ void InstructionSelector::VisitAtomicStore(Node* node) {
V(16x8) \
V(8x16)
+#define SIMD_ZERO_OP_LIST(V) \
+ V(Simd128Zero) \
+ V(Simd1x4Zero) \
+ V(Simd1x8Zero) \
+ V(Simd1x16Zero)
+
#define SIMD_UNOP_LIST(V) \
V(Float32x4FromInt32x4) \
V(Float32x4FromUint32x4) \
@@ -2271,9 +2277,9 @@ void InstructionSelector::VisitAtomicStore(Node* node) {
V(Int8x16ShiftRightByScalar) \
V(Uint8x16ShiftRightByScalar)
-#define SIMD_VISIT_SPLAT(Type) \
- void InstructionSelector::VisitCreate##Type(Node* node) { \
- VisitRR(this, kArm##Type##Splat, node); \
+#define SIMD_VISIT_SPLAT(Type) \
+ void InstructionSelector::Visit##Type##Splat(Node* node) { \
+ VisitRR(this, kArm##Type##Splat, node); \
}
SIMD_TYPE_LIST(SIMD_VISIT_SPLAT)
#undef SIMD_VISIT_SPLAT
@@ -2292,6 +2298,14 @@ SIMD_TYPE_LIST(SIMD_VISIT_EXTRACT_LANE)
SIMD_TYPE_LIST(SIMD_VISIT_REPLACE_LANE)
#undef SIMD_VISIT_REPLACE_LANE
+#define SIMD_VISIT_ZERO_OP(Name) \
+ void InstructionSelector::Visit##Name(Node* node) { \
+ ArmOperandGenerator g(this); \
+ Emit(kArmSimd128Zero, g.DefineAsRegister(node), g.DefineAsRegister(node)); \
+ }
+SIMD_ZERO_OP_LIST(SIMD_VISIT_ZERO_OP)
+#undef SIMD_VISIT_ZERO_OP
+
#define SIMD_VISIT_UNOP(Name) \
void InstructionSelector::Visit##Name(Node* node) { \
VisitRR(this, kArm##Name, node); \

Powered by Google App Engine
This is Rietveld 408576698