Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/simd-scalar-lowering.cc

Issue 2719483002: [V8] Rename SIMD Create methods and add initialization operators. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/simd-scalar-lowering.cc
diff --git a/src/compiler/simd-scalar-lowering.cc b/src/compiler/simd-scalar-lowering.cc
index 19ffe9377582a9264d8b870c58705ace846a0d86..601ccb20a2bab27682adffe0140d2860691ddd5e 100644
--- a/src/compiler/simd-scalar-lowering.cc
+++ b/src/compiler/simd-scalar-lowering.cc
@@ -74,13 +74,13 @@ void SimdScalarLowering::LowerGraph() {
#define FOREACH_INT32X4_OPCODE(V) \
V(Int32x4Add) \
V(Int32x4ExtractLane) \
- V(CreateInt32x4) \
+ V(Int32x4Splat) \
V(Int32x4ReplaceLane)
#define FOREACH_FLOAT32X4_OPCODE(V) \
V(Float32x4Add) \
V(Float32x4ExtractLane) \
- V(CreateFloat32x4) \
+ V(Float32x4Splat) \
V(Float32x4ReplaceLane)
void SimdScalarLowering::SetLoweredType(Node* node, Node* output) {
@@ -385,14 +385,14 @@ void SimdScalarLowering::LowerNode(Node* node) {
LowerBinaryOp(node, rep_type, machine()->Float32Add());
break;
}
- case IrOpcode::kCreateInt32x4:
- case IrOpcode::kCreateFloat32x4: {
+ case IrOpcode::kInt32x4Splat:
+ case IrOpcode::kFloat32x4Splat: {
Node* rep_node[kMaxLanes];
for (int i = 0; i < kMaxLanes; ++i) {
- if (HasReplacement(0, node->InputAt(i))) {
- rep_node[i] = GetReplacements(node->InputAt(i))[0];
+ if (HasReplacement(0, node->InputAt(0))) {
+ rep_node[i] = GetReplacements(node->InputAt(0))[0];
} else {
- rep_node[i] = node->InputAt(i);
+ rep_node[i] = node->InputAt(0);
bbudge 2017/02/24 13:23:47 Aseem, I wasn't sure what to do here. This seemed
}
}
ReplaceNode(node, rep_node);

Powered by Google App Engine
This is Rietveld 408576698