Rename SkipServiceWorker to ServiceWorkerMode

Rename SkipServiceWorker to ServiceWorkerMode

This was changed in the following PR to the Fetch standard:
  https://github.com/whatwg/fetch/pull/435

BUG=592188
Review-Url: https://codereview.chromium.org/2714423002
Cr-Commit-Position: refs/heads/master@{#453432}
Committed: https://chromium.googlesource.com/chromium/src/+/34669ef1214c412d168021ba04bce9ac1dce4bd5

[Peter Beverloo, 2017-02-27 04:35:49]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 04:36:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-02-27 04:44:43]

peter@chromium.org changed reviewers:
+ horo@chromium.org, kinuko@chromium.org

[Peter Beverloo, 2017-02-27 04:44:44]

+horo for Service Workers
+kinuko for loading / OWNERS scope

This is a largely mechanical rename, but please note that values have flipped
around. (E.g. SkipServiceWorker::All is now ServiceWorkerMode::None.) This makes
our implementation match the updated spec again.

[Peter Beverloo, 2017-02-27 05:47:50]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 05:48:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-27 06:01:53]

Looking good.  ServiceWorkerMode sounds pretty general, do we want to name it
FetchServiceWorkerMode or something a little more specific?  (Deferring the
final judge to horo though)

[commit-bot: I haz the power, 2017-02-27 06:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 06:02:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2017-02-27 06:02:31]

lgtm

Thank you!

[kinuko, 2017-02-27 06:16:12]

On 2017/02/27 06:02:31, horo wrote:
> lgtm
> 
> Thank you!

Well, lgtm/2 as far as horo's happy :)

[Peter Beverloo, 2017-02-27 07:02:14]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 07:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-02-27 07:05:20]

Thank you!

Terminology-wise, I think ServiceWorkerMode is fine because it's a property of
Request(/Fetch)-related objects, and not an Service Worker-related object.

[kinuko, 2017-02-27 07:14:01]

On 2017/02/27 07:05:20, Peter Beverloo wrote:
> Thank you!
> 
> Terminology-wise, I think ServiceWorkerMode is fine because it's a property of
> Request(/Fetch)-related objects, and not an Service Worker-related object.

Yep, sgtm.

[commit-bot: I haz the power, 2017-02-27 10:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 10:02:36]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-02-27 10:04:57]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-02-27 10:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 10:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 10:11:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Beverloo, 2017-02-27 10:12:01]

peter@chromium.org changed reviewers:
+ tsepez@chromium.org

[Peter Beverloo, 2017-02-27 10:12:02]

+tsepez for IPC change

[Tom Sepez, 2017-02-27 17:13:49]

RS LGTM on renaming enum values

[Peter Beverloo, 2017-02-28 01:03:43]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:04:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:11:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488243823649260,
"parent_rev": "07bec82ec92e1047614b17192569f69260945d42", "commit_rev":
"34669ef1214c412d168021ba04bce9ac1dce4bd5"}

[commit-bot: I haz the power, 2017-02-28 01:12:20]

Description was changed from

==========
Rename SkipServiceWorker to ServiceWorkerMode

This was changed in the following PR to the Fetch standard:
  https://github.com/whatwg/fetch/pull/435

BUG=592188
==========

to

==========
Rename SkipServiceWorker to ServiceWorkerMode

This was changed in the following PR to the Fetch standard:
  https://github.com/whatwg/fetch/pull/435

BUG=592188

Review-Url: https://codereview.chromium.org/2714423002
Cr-Commit-Position: refs/heads/master@{#453432}
Committed:
https://chromium.googlesource.com/chromium/src/+/34669ef1214c412d168021ba04bc...
==========

[commit-bot: I haz the power, 2017-02-28 01:12:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/34669ef1214c412d168021ba04bc...