Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

Expand FrameSeleciton::isRange()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isRange()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isRange()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isRange()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2708703003
Cr-Commit-Position: refs/heads/master@{#451781}
Committed: https://chromium.googlesource.com/chromium/src/+/f895c25f6f60ffbddc9afac93d134a677551b37b

[yosin_UTC9, 2017-02-21 04:12:02]

Description was changed from

==========
2017-02-21T13:10:49

2017-02-21T13:10:40

BUG=
==========

to

==========
Expand FrameSeleciton::isRange()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isRange()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isRange()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- base() 
- extent()
- start()
- end()
- isNone() 
- isRange()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 04:12:10]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 04:12:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 05:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 05:42:12]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2017-02-21 05:52:52]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 05:53:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 07:09:00]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-21 07:09:01]

PTAL

Changes in core/editing/, core/frame/, core/html, core/input, core/page and web/

[tkent, 2017-02-21 07:14:38]

lgtm

[commit-bot: I haz the power, 2017-02-21 07:20:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 07:20:25]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2017-02-21 07:34:48]

Description was changed from

==========
Expand FrameSeleciton::isRange()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isRange()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isRange()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- base() 
- extent()
- start()
- end()
- isNone() 
- isRange()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::isRange()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isRange()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isRange()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isRange()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 07:34:52]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 07:35:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 10:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 10:37:32]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2017-02-21 12:29:46]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 12:30:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 13:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 13:11:10]

Failed to apply patch for
third_party/WebKit/Source/core/editing/FrameSelection.h:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/editing/FrameSelection.h:219
  error: third_party/WebKit/Source/core/editing/FrameSelection.h: patch does not
apply

Patch:       third_party/WebKit/Source/core/editing/FrameSelection.h
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h
b/third_party/WebKit/Source/core/editing/FrameSelection.h
index
bcb452cac01288b9d58317c2022b5a018014805e..d46d71c9d7326db1df4d20f5d44c835dd343a0d2
100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -219,9 +219,6 @@ class CORE_EXPORT FrameSelection final
   bool isCaret() const {
     return computeVisibleSelectionInDOMTreeDeprecated().isCaret();
   }
-  bool isRange() const {
-    return computeVisibleSelectionInDOMTreeDeprecated().isRange();
-  }
   bool isInPasswordField() const;
   bool isDirectional() const { return selectionInDOMTree().isDirectional(); }

[yosin_UTC9, 2017-02-21 14:54:59]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-02-21 14:54:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2708703003/#ps40001
(title: "2017-02-21T23:48:22 rebase")

[commit-bot: I haz the power, 2017-02-21 14:55:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:03:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487688899328070,
"parent_rev": "304ce3931f9c5c4f63a94de6047b242ae239925d", "commit_rev":
"f895c25f6f60ffbddc9afac93d134a677551b37b"}

[commit-bot: I haz the power, 2017-02-21 17:04:29]

Description was changed from

==========
Expand FrameSeleciton::isRange()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isRange()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isRange()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isRange()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::isRange()  to increase chances of hoisting update layout

This patch expands |FrameSeleciton::isRange()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().isRange()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isRange()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2708703003
Cr-Commit-Position: refs/heads/master@{#451781}
Committed:
https://chromium.googlesource.com/chromium/src/+/f895c25f6f60ffbddc9afac93d13...
==========

[commit-bot: I haz the power, 2017-02-21 17:04:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f895c25f6f60ffbddc9afac93d13...