third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T23:48:22 rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index c96ff69f4da233f86bf94261dc424a0ac5305eb8..29fe2e47346f6676bf226bbba756bea76c07e88e 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -1839,7 +1839,8 @@ WebInputEventResult EventHandler::sendContextMenuEventForKey(

VisualViewport& visualViewport = frameHost()->visualViewport();

if (!overrideTargetElement && start.anchorNode() &&

- (selection.rootEditableElement() || selection.isRange())) {

+ (selection.rootEditableElement() ||

+ selection.computeVisibleSelectionInDOMTreeDeprecated().isRange())) {

// TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets

// needs to be audited. See http://crbug.com/590369 for more details.

doc->updateStyleAndLayoutIgnorePendingStylesheets();