Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 402 matching lines @@
   return !element.getElementsByTagName(tagName.localName())->isEmpty();
 }
 
 static TriState selectionListState(const FrameSelection& selection,
                                    const QualifiedName& tagName) {
   if (selection.computeVisibleSelectionInDOMTreeDeprecated().isCaret()) {
     if (enclosingElementWithTag(
             selection.computeVisibleSelectionInDOMTreeDeprecated().start(),
             tagName))
       return TrueTriState;
-  } else if (selection.isRange()) {
+  } else if (selection.computeVisibleSelectionInDOMTreeDeprecated().isRange()) {
     Element* startElement = enclosingElementWithTag(
         selection.computeVisibleSelectionInDOMTreeDeprecated().start(),
         tagName);
     Element* endElement = enclosingElementWithTag(
         selection.computeVisibleSelectionInDOMTreeDeprecated().end(), tagName);
 
     if (startElement && endElement && startElement == endElement) {
       // If the selected list has the different type of list as child, return
       // |FalseTriState|.
       // See http://crbug.com/385374
@@ skipping 1498 matching lines @@
 }
 
 static bool enabledRangeInEditableText(LocalFrame& frame,
                                        Event*,
                                        EditorCommandSource) {
   frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
   // We should update selection to canonicalize with current layout and style,
   // before accessing |FrameSelection::selection()|.
   frame.selection().updateIfNeeded();
-  return frame.selection().isRange() && frame.selection().isContentEditable();
+  return frame.selection()
+             .computeVisibleSelectionInDOMTreeDeprecated()
+             .isRange() &&
+         frame.selection().isContentEditable();
 }
 
 static bool enabledRangeInRichlyEditableText(LocalFrame& frame,
                                              Event*,
                                              EditorCommandSource) {
   frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
   // We should update selection to canonicalize with current layout and style,
   // before accessing |FrameSelection::selection()|.
   frame.selection().updateIfNeeded();
-  return frame.selection().isRange() &&
+  return frame.selection()
+             .computeVisibleSelectionInDOMTreeDeprecated()
+             .isRange() &&
          frame.selection()
              .computeVisibleSelectionInDOMTreeDeprecated()
              .isContentRichlyEditable();
 }
 
 static bool enabledRedo(LocalFrame& frame, Event*, EditorCommandSource) {
   return frame.editor().canRedo();
 }
 
 static bool enabledUndo(LocalFrame& frame, Event*, EditorCommandSource) {
@@ skipping 793 matching lines @@
           *m_frame, DirectionBackward, WordGranularity);
     case WebEditingCommandType::DeleteWordForward:
       return RangesFromCurrentSelectionOrExtendCaret(*m_frame, DirectionForward,
                                                      WordGranularity);
     default:
       return targetRangesForInputEvent(*target);
   }
 }
 
 }  // namespace blink