third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T23:48:22 rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 89d55678ff7d6f26ed137803c28d2265c307216c..7a1c25a7383ffffcb86d09f88dcdbf1000fa9c86 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1149,7 +1149,8 @@ void WebLocalFrameImpl::selectWordAroundPosition(LocalFrame* frame,

bool WebLocalFrameImpl::selectWordAroundCaret() {

TRACE_EVENT0("blink", "WebLocalFrameImpl::selectWordAroundCaret");

FrameSelection& selection = frame()->selection();

- if (selection.isNone() || selection.isRange())

+ if (selection.isNone() ||

+ selection.computeVisibleSelectionInDOMTreeDeprecated().isRange())

return false;

// TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets

« no previous file with comments | « third_party/WebKit/Source/core/page/DragController.cpp ('k') | no next file » | no next file with comments »