third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp - Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Issue 2708703003: Expand FrameSeleciton::isRange() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T23:48:22 rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

index ab9a3abca165d46de01e60d4895eea4008ee038d..a1a928da1632941dbc395da6407c053508b5799b 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

@@ -153,7 +153,9 @@ void TypingCommand::deleteSelection(Document& document, Options options) {

LocalFrame* frame = document.frame();

DCHECK(frame);

- if (!frame->selection().isRange())

+ if (!frame->selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .isRange())

return;

if (TypingCommand* lastTypingCommand =