Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

third_party/WebKit/Source/core/editing/SelectionController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 707 matching lines @@
 
   if (!selection().isAvailable())
     return false;
 
   if (!m_mouseDownAllowsMultiClick)
     return handleMousePressEventSingleClick(event);
 
   if (event.event().button != WebPointerProperties::Button::Left)
     return false;
 
-  if (selection().isRange()) {
+  if (selection().computeVisibleSelectionInDOMTreeDeprecated().isRange()) {
     // A double-click when range is already selected
     // should not change the selection.  So, do not call
     // selectClosestWordFromMouseEvent, but do set
     // m_beganSelectingText to prevent handleMouseReleaseEvent
     // from setting caret selection.
     m_selectionState = SelectionState::ExtendedSelection;
   } else {
     selectClosestWordFromMouseEvent(event);
   }
   return true;
@@ skipping 107 matching lines @@
 
   bool handled = false;
   m_mouseDownMayStartSelect = false;
   // Clear the selection if the mouse didn't move after the last mouse
   // press and it's not a context menu click.  We do this so when clicking
   // on the selection, the selection goes away.  However, if we are
   // editing, place the caret.
   if (m_mouseDownWasSingleClickInSelection &&
       m_selectionState != SelectionState::ExtendedSelection &&
       dragStartPos == flooredIntPoint(event.event().positionInRootFrame()) &&
-      selection().isRange() &&
+      selection().computeVisibleSelectionInDOMTreeDeprecated().isRange() &&
       event.event().button != WebPointerProperties::Button::Right) {
     // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
     // needs to be audited.  See http://crbug.com/590369 for more details.
     m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
     SelectionInFlatTree::Builder builder;
     Node* node = event.innerNode();
     if (node && node->layoutObject() && hasEditableStyle(*node)) {
       const VisiblePositionInFlatTree pos =
           visiblePositionOfHitTestResult(event.hitTestResult());
@@ skipping 212 matching lines @@
 
 bool isExtendingSelection(const MouseEventWithHitTestResults& event) {
   bool isMouseDownOnLinkOrImage =
       event.isOverLink() || event.hitTestResult().image();
   return (event.event().modifiers() & WebInputEvent::Modifiers::ShiftKey) !=
              0 &&
          !isMouseDownOnLinkOrImage;
 }
 
 }  // namespace blink