Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout This patch expands |FrameSeleciton::rootEditableElement()| to increase chance of hoisting update layout. Note: This is mechanical change to replace |selection().rootEditableElement()| by |selection().computeVisibleSelectionInDOMTreeDeprecated().rootEditableElement()| Following patch will remove deprecated version. This patch is apart of expanding expensive member functions in |FrameSelection|: - rootEditableElement() - hasEditableStyle() - isContentEditable() - isContentRichlyEditable() - getSelectionType() - base() - extent() - start() - end() - isNone() - isCaret() - isRange() BUG=694360 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2704933006 Cr-Commit-Position: refs/heads/master@{#451724} Committed: https://chromium.googlesource.com/chromium/src/+/ddf5cfcdc3c53c40d09312564084d5ca638be348

Patch Set 1 : 2017-02-21T15:42:51 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -20 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 8 chunks +37 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRange.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL Changes in core/dom/, core/editing/, core/page, and web/
3 years, 10 months ago (2017-02-21 08:16:07 UTC) #6
tkent
lgtm
3 years, 10 months ago (2017-02-21 08:28:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704933006/1
3 years, 10 months ago (2017-02-21 08:30:48 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 11:11:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ddf5cfcdc3c53c40d09312564084...

Powered by Google App Engine
This is Rietveld 408576698