third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp - Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp

Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T15:42:51 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/page/DragController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp b/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp

index 8132dae22d5680ce2c349d066324299463698d29..f57bda0704f29213d06f1c977c37ed7f533eba4f 100644

--- a/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp

@@ -65,7 +65,9 @@ void RemoveFormatCommand::doApply(EditingState* editingState) {

// Get the default style for this editable root, it's the style that we'll

// give the content that we're operating on.

- Element* root = frame->selection().rootEditableElement();

+ Element* root = frame->selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .rootEditableElement();

EditingStyle* defaultStyle = EditingStyle::create(root);

// We want to remove everything but transparent background.