Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout

third_party/WebKit/Source/core/editing/InputMethodController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 261 matching lines @@
       return false;
     const SelectionInDOMTree& selection =
         SelectionInDOMTree::Builder()
             .setBaseAndExtent(oldSelectionRange)
             .setIsHandleVisible(isHandleVisible)
             .build();
     frame().selection().setSelection(selection, FrameSelection::CloseTyping);
     return true;
   }
 
-  Element* rootEditableElement = frame().selection().rootEditableElement();
+  Element* rootEditableElement =
+      frame()
+          .selection()
+          .computeVisibleSelectionInDOMTreeDeprecated()
+          .rootEditableElement();
   if (!rootEditableElement)
     return false;
   PlainTextRange compositionRange =
       PlainTextRange::create(*rootEditableElement, *m_compositionRange);
   if (compositionRange.isNull())
     return false;
 
   clear();
 
   if (!moveCaret(compositionRange.end()))
@@ skipping 74 matching lines @@
     document().markers().addCompositionMarker(
         ephemeralLineRange.startPosition(), ephemeralLineRange.endPosition(),
         underline.color(), underline.thick(), underline.backgroundColor());
   }
 }
 
 bool InputMethodController::replaceCompositionAndMoveCaret(
     const String& text,
     int relativeCaretPosition,
     const Vector<CompositionUnderline>& underlines) {
-  Element* rootEditableElement = frame().selection().rootEditableElement();
+  Element* rootEditableElement =
+      frame()
+          .selection()
+          .computeVisibleSelectionInDOMTreeDeprecated()
+          .rootEditableElement();
   if (!rootEditableElement)
     return false;
   DCHECK(hasComposition());
   PlainTextRange compositionRange =
       PlainTextRange::create(*rootEditableElement, *m_compositionRange);
   if (compositionRange.isNull())
     return false;
   int textStart = compositionRange.start();
 
   if (!replaceComposition(text))
@@ skipping 24 matching lines @@
     const Vector<CompositionUnderline>& underlines) {
   PlainTextRange selectionRange = getSelectionOffsets();
   if (selectionRange.isNull())
     return false;
   int textStart = selectionRange.start();
 
   if (text.length()) {
     if (!insertText(text))
       return false;
 
-    Element* rootEditableElement = frame().selection().rootEditableElement();
+    Element* rootEditableElement =
+        frame()
+            .selection()
+            .computeVisibleSelectionInDOMTreeDeprecated()
+            .rootEditableElement();
     if (rootEditableElement) {
       addCompositionUnderlines(underlines, rootEditableElement, textStart);
     }
   }
 
   int absoluteCaretPosition = computeAbsoluteCaretPosition(
       textStart, text.length(), relativeCaretPosition);
   return moveCaret(absoluteCaretPosition);
 }
 
@@ skipping 186 matching lines @@
       static_cast<int>(getSelectionOffsets().start());
   const int start = selectionOffsetsStart + selectionStart;
   const int end = selectionOffsetsStart + selectionEnd;
   return createRangeForSelection(start, end, textLength);
 }
 
 void InputMethodController::setCompositionFromExistingText(
     const Vector<CompositionUnderline>& underlines,
     unsigned compositionStart,
     unsigned compositionEnd) {
-  Element* editable = frame().selection().rootEditableElement();
+  Element* editable = frame()
+                          .selection()
+                          .computeVisibleSelectionInDOMTreeDeprecated()
+                          .rootEditableElement();
   if (!editable)
     return;
 
   DCHECK(!document().needsLayoutTreeUpdate());
 
   const EphemeralRange range =
       PlainTextRange(compositionStart, compositionEnd).createRange(*editable);
   if (range.isNull())
     return;
 
@@ skipping 42 matching lines @@
   ContainerNode* editable =
       frame().selection().rootEditableElementOrTreeScopeRootNode();
   DCHECK(editable);
   return PlainTextRange::create(*editable, range);
 }
 
 EphemeralRange InputMethodController::ephemeralRangeForOffsets(
     const PlainTextRange& offsets) const {
   if (offsets.isNull())
     return EphemeralRange();
-  Element* rootEditableElement = frame().selection().rootEditableElement();
+  Element* rootEditableElement =
+      frame()
+          .selection()
+          .computeVisibleSelectionInDOMTreeDeprecated()
+          .rootEditableElement();
   if (!rootEditableElement)
     return EphemeralRange();
 
   DCHECK(!document().needsLayoutTreeUpdate());
 
   return offsets.createRange(*rootEditableElement);
 }
 
 bool InputMethodController::setSelectionOffsets(
     const PlainTextRange& selectionOffsets,
@@ skipping 16 matching lines @@
 }
 
 PlainTextRange InputMethodController::createRangeForSelection(
     int start,
     int end,
     size_t textLength) const {
   // In case of exceeding the left boundary.
   start = std::max(start, 0);
   end = std::max(end, start);
 
-  Element* rootEditableElement = frame().selection().rootEditableElement();
+  Element* rootEditableElement =
+      frame()
+          .selection()
+          .computeVisibleSelectionInDOMTreeDeprecated()
+          .rootEditableElement();
   if (!rootEditableElement)
     return PlainTextRange();
   const EphemeralRange& range =
       EphemeralRange::rangeOfContents(*rootEditableElement);
   if (range.isNull())
     return PlainTextRange();
 
   const TextIteratorBehavior& behavior =
       TextIteratorBehavior::Builder()
           .setEmitsObjectReplacementCharacter(true)
@@ skipping 66 matching lines @@
 }
 
 // TODO(yabinh): We should reduce the number of selectionchange events.
 void InputMethodController::deleteSurroundingText(int before, int after) {
   if (!editor().canEdit())
     return;
   const PlainTextRange selectionOffsets(getSelectionOffsets());
   if (selectionOffsets.isNull())
     return;
   Element* const rootEditableElement =
-      frame().selection().rootEditableElement();
+      frame()
+          .selection()
+          .computeVisibleSelectionInDOMTreeDeprecated()
+          .rootEditableElement();
   if (!rootEditableElement)
     return;
   int selectionStart = static_cast<int>(selectionOffsets.start());
   int selectionEnd = static_cast<int>(selectionOffsets.end());
 
   // Select the text to be deleted before selectionStart.
   if (before > 0 && selectionStart > 0) {
     // In case of exceeding the left boundary.
     const int start = std::max(selectionStart - before, 0);
 
@@ skipping 43 matching lines @@
 
 WebTextInputInfo InputMethodController::textInputInfo() const {
   WebTextInputInfo info;
   if (!isAvailable())
     return info;
 
   if (!frame().selection().isAvailable()) {
     // plugins/mouse-capture-inside-shadow.html reaches here.
     return info;
   }
-  Element* element = frame().selection().rootEditableElement();
+  Element* element = frame()
+                         .selection()
+                         .computeVisibleSelectionInDOMTreeDeprecated()
+                         .rootEditableElement();
   if (!element)
     return info;
 
   info.inputMode = inputModeOfFocusedElement();
   info.type = textInputType();
   info.flags = textInputFlags();
   if (info.type == WebTextInputTypeNone)
     return info;
 
   if (!frame().editor().canEdit())
@@ skipping 195 matching lines @@
   finishComposingText(DoNotKeepSelection);
 }
 
 DEFINE_TRACE(InputMethodController) {
   visitor->trace(m_frame);
   visitor->trace(m_compositionRange);
   SynchronousMutationObserver::trace(visitor);
 }
 
 }  // namespace blink