third_party/WebKit/Source/web/WebRange.cpp - Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRange.cpp

Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T15:42:51 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRange.cpp

diff --git a/third_party/WebKit/Source/web/WebRange.cpp b/third_party/WebKit/Source/web/WebRange.cpp

index e3194e31c2d3864593820b8418611c563795ef58..803d8429d7e625dd7e1646887933663fa22a3382 100644

--- a/third_party/WebKit/Source/web/WebRange.cpp

+++ b/third_party/WebKit/Source/web/WebRange.cpp

@@ -61,7 +61,9 @@ WebRange::WebRange(const PlainTextRange& range) {

}

EphemeralRange WebRange::createEphemeralRange(LocalFrame* frame) const {

- Element* selectionRoot = frame->selection().rootEditableElement();

+ Element* selectionRoot = frame->selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .rootEditableElement();

ContainerNode* scope =

selectionRoot ? selectionRoot : frame->document()->documentElement();