Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: third_party/WebKit/Source/web/WebRange.cpp

Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-21T15:42:51 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 WebRange::WebRange(const PlainTextRange& range) { 55 WebRange::WebRange(const PlainTextRange& range) {
56 if (range.isNull()) 56 if (range.isNull())
57 return; 57 return;
58 58
59 m_start = range.start(); 59 m_start = range.start();
60 m_end = range.end(); 60 m_end = range.end();
61 } 61 }
62 62
63 EphemeralRange WebRange::createEphemeralRange(LocalFrame* frame) const { 63 EphemeralRange WebRange::createEphemeralRange(LocalFrame* frame) const {
64 Element* selectionRoot = frame->selection().rootEditableElement(); 64 Element* selectionRoot = frame->selection()
65 .computeVisibleSelectionInDOMTreeDeprecated()
66 .rootEditableElement();
65 ContainerNode* scope = 67 ContainerNode* scope =
66 selectionRoot ? selectionRoot : frame->document()->documentElement(); 68 selectionRoot ? selectionRoot : frame->document()->documentElement();
67 69
68 return PlainTextRange(m_start, m_end).createRange(*scope); 70 return PlainTextRange(m_start, m_end).createRange(*scope);
69 } 71 }
70 72
71 } // namespace blink 73 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/DragController.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698