third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2704933006: Expand FrameSeleciton::rootEditableElement() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T15:42:51 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index af6c0c9ee6be81a70fe3c60681a4781ea6f58736..dcd44c7ca717db5d9f68c1b52934dc4aa4274bd9 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -263,7 +263,10 @@ bool Editor::handleTextEvent(TextEvent* event) {

}

bool Editor::canEdit() const {

- return frame().selection().rootEditableElement();

+ return frame()

+ .selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .rootEditableElement();

}

bool Editor::canEditRichly() const {